Optimize alias subset recording

When an alias-set is an already existing subset there is no need
to re-record its children as childs of the parent.

2020-01-15  Richard Biener  <rguenther@suse.de>

	* alias.c (record_alias_subset): Avoid redundant work when
	subset is already recorded.

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 4da4d045ce82f07b64bada77d2f52bdd1f01419c..8ef85773d7a636315366055261596b6bd7a3a547 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,8 @@
+2020-01-15  Richard Biener  <rguenther@suse.de>
+
+       * alias.c (record_alias_subset): Avoid redundant work when
+       subset is already recorded.
+
 2020-01-14  David Malcolm  <dmalcolm@redhat.com>
 
        * doc/invoke.texi (-fdiagnostics-show-cwe): Add note that some of

diff --git a/gcc/alias.c b/gcc/alias.c
index 9629b5a9f48460cc67a228e3a7f9e7bcf702a5a4..3794f9b6a9ee249e924e90985aabcae2bff5d582 100644 (file)
--- a/gcc/alias.c
+++ b/gcc/alias.c
@@ -1164,10 +1164,16 @@ record_alias_subset (alias_set_type superset, alias_set_type subset)
     superset_entry->has_zero_child = 1;
   else
     {
-      subset_entry = get_alias_set_entry (subset);
       if (!superset_entry->children)
        superset_entry->children
          = hash_map<alias_set_hash, int>::create_ggc (64);
+
+      /* Enter the SUBSET itself as a child of the SUPERSET.  If it was
+        already there we're done.  */
+      if (superset_entry->children->put (subset, 0))
+       return;
+
+      subset_entry = get_alias_set_entry (subset);
       /* If there is an entry for the subset, enter all of its children
         (if they are not already present) as children of the SUPERSET.  */
       if (subset_entry)
@@ -1185,9 +1191,6 @@ record_alias_subset (alias_set_type superset, alias_set_type subset)
                superset_entry->children->put ((*iter).first, (*iter).second);
            }
        }
-
-      /* Enter the SUBSET itself as a child of the SUPERSET.  */
-      superset_entry->children->put (subset, 0);
     }
 }