glsl: Make ir_validate actually visit ir_if nodes.
authorKenneth Graunke <kenneth@whitecape.org>
Thu, 18 Aug 2011 20:52:28 +0000 (13:52 -0700)
committerKenneth Graunke <kenneth@whitecape.org>
Mon, 22 Aug 2011 17:30:47 +0000 (10:30 -0700)
There is no ir_hierarchical_visitor::visit(ir_if *) method, since ir_if
is not a leaf node.  Instead, there are visit_enter and visit_leave
methods.  Use visit_enter arbitrarily (either would work fine, though
visit_enter will catch errors sooner).

Found thanks to a warning emitted by Clang.

Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
src/glsl/ir_validate.cpp

index b3ca72ef0c218eadb4dc6833a4e9f2acfd3b6c5a..2d1c6097c57d0e0292489a58109cada94575022c 100644 (file)
@@ -59,7 +59,8 @@ public:
 
    virtual ir_visitor_status visit(ir_variable *v);
    virtual ir_visitor_status visit(ir_dereference_variable *ir);
-   virtual ir_visitor_status visit(ir_if *ir);
+
+   virtual ir_visitor_status visit_enter(ir_if *ir);
 
    virtual ir_visitor_status visit_leave(ir_loop *ir);
    virtual ir_visitor_status visit_enter(ir_function *ir);
@@ -102,7 +103,7 @@ ir_validate::visit(ir_dereference_variable *ir)
 }
 
 ir_visitor_status
-ir_validate::visit(ir_if *ir)
+ir_validate::visit_enter(ir_if *ir)
 {
    if (ir->condition->type != glsl_type::bool_type) {
       printf("ir_if condition %s type instead of bool.\n",