Fix PR binutils/22923.

A static buffer in get_ver_flags may overflow when e.g. German translation
is longer than English original. Avoid that by expanding the buffer.

diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index 3f3a9ddb5670253437dac1a3b29d5777a4e306f4..52fe2d37416e022d44f2a86000ff655f3c47616f 100644 (file)
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,3 +1,9 @@
+2018-03-07  Paul Pluzhnikov  <ppluzhnikov@google.com>
+
+       PR binutils/22923
+       * binutils/readelf.c (get_ver_flags): Expand buffer to avoid
+       overflow.
+
 2018-03-07  Alan Modra  <amodra@gmail.com>
 
        * configure.ac: Add objdump_private_desc_xcoff for rs6000.

diff --git a/binutils/readelf.c b/binutils/readelf.c
index e3af50a9c94c1fd232bb4d4ecc6b6583a2de5261..b85db9f97cef6893376effd33514c96dd53bf2ac 100644 (file)
--- a/binutils/readelf.c
+++ b/binutils/readelf.c
@@ -10212,7 +10212,7 @@ process_dynamic_section (Filedata * filedata)
 static char *
 get_ver_flags (unsigned int flags)
 {
-  static char buff[32];
+  static char buff[128];
 
   buff[0] = 0;