nir/lower_bit_size: fix lowering of {imul,umul}_high
authorRhys Perry <pendingchaos02@gmail.com>
Tue, 31 Mar 2020 12:52:43 +0000 (13:52 +0100)
committerMarge Bot <eric+marge@anholt.net>
Thu, 23 Apr 2020 10:57:38 +0000 (10:57 +0000)
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4387>

src/compiler/nir/nir_lower_bit_size.c

index 3ba63c81adccc02e22f826205d8ae2dbbeb04ae2..100ac4864a5896fe36aec0afc058d6ea1c0cd2bd 100644 (file)
@@ -70,8 +70,18 @@ lower_instr(nir_builder *bld, nir_alu_instr *alu, unsigned bit_size)
    }
 
    /* Emit the lowered ALU instruction */
-   nir_ssa_def *lowered_dst =
-      nir_build_alu(bld, op, srcs[0], srcs[1], srcs[2], srcs[3]);
+   nir_ssa_def *lowered_dst = NULL;
+   if (op == nir_op_imul_high || op == nir_op_umul_high) {
+      assert(dst_bit_size * 2 <= bit_size);
+      nir_ssa_def *lowered_dst = nir_imul(bld, srcs[0], srcs[1]);
+      if (nir_op_infos[op].output_type & nir_type_uint)
+         lowered_dst = nir_ushr(bld, lowered_dst, nir_imm_int(bld, dst_bit_size));
+      else
+         lowered_dst = nir_ishr(bld, lowered_dst, nir_imm_int(bld, dst_bit_size));
+   } else {
+      lowered_dst = nir_build_alu(bld, op, srcs[0], srcs[1], srcs[2], srcs[3]);
+   }
+
 
    /* Convert result back to the original bit-size */
    nir_alu_type type = nir_op_infos[op].output_type;