package/gobject-introspection: depend on python3
authorAdam Duskett <Aduskett@gmail.com>
Sat, 22 Feb 2020 21:31:42 +0000 (13:31 -0800)
committerYann E. MORIN <yann.morin.1998@free.fr>
Sat, 22 Feb 2020 21:40:32 +0000 (22:40 +0100)
Currently, the Config.in file has the line:
select BR2_PACKAGE_PYTHON3 if !BR2_PACKAGE_PYTHON

This line is incorrect as gobject-introspection does not support python2.
Instead, remove the select line and make python3 a dependency with a new
message that explains that gobject-introspection requires python3.

Signed-off-by: Adam Duskett <Aduskett@gmail.com>
[yann.morin.1998@free.fr:
  - move the explanations from the commit log to the code
]
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
package/gobject-introspection/Config.in

index 0537cc0404829db350c241969290ccf314712267..e312852cf28f6e819c6cf67062ed55cf8944d160 100644 (file)
@@ -9,11 +9,18 @@ config BR2_PACKAGE_GOBJECT_INTROSPECTION
        # can be verified.
        depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
        depends on BR2_TOOLCHAIN_USES_GLIBC
+       # gobject-introspection does not require python3 to run on the
+       # target; however, because the tools run in a qemu wrapper, a
+       # cross-compiled python3 must be installed to staging. As there
+       # is no current mechanism to tell Buildroot only to install
+       # python to staging, then python must also be installed
+       # unconditionally to the target when building
+       # gobject-introspection.
+       depends on BR2_PACKAGE_PYTHON3
        select BR2_PACKAGE_HOST_QEMU
        select BR2_PACKAGE_HOST_QEMU_LINUX_USER_MODE
        select BR2_PACKAGE_LIBFFI
        select BR2_PACKAGE_LIBGLIB2
-       select BR2_PACKAGE_PYTHON3 if !BR2_PACKAGE_PYTHON
        select BR2_PACKAGE_ZLIB
        help
          GObject introspection is a middleware layer between C
@@ -25,6 +32,9 @@ config BR2_PACKAGE_GOBJECT_INTROSPECTION
 
          https://wiki.gnome.org/action/show/Projects/GObjectIntrospection
 
+comment "gobject-introspection needs python3"
+       depends on !BR2_PACKAGE_PYTHON3
+
 comment "gobject-introspection needs a glibc toolchain, gcc >= 4.9"
        depends on BR2_USE_MMU
        depends on BR2_PACKAGE_HOST_QEMU_ARCH_SUPPORTS