re PR tree-optimization/87117 (ICE in eliminate_dom_walker::eliminate_cleanup(bool...

2018-08-28  Richard Biener  <rguenther@suse.de>

	PR tree-optimization/87117
	* tree-ssa-operands.c (add_stmt_operand): STRING_CST may
	get virtual operands.
	(get_expr_operands): Handle STRING_CST like other decls.

	* gcc.dg/lvalue-5.c: New testcase.

From-SVN: r263908

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 33242431ac0c1dedc20f421ac3508ed32074eaea..b8c25ba6ea76a15357df703d97598a325400c8f4 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,10 @@
+2018-08-28  Richard Biener  <rguenther@suse.de>
+
+       PR tree-optimization/87117
+       * tree-ssa-operands.c (add_stmt_operand): STRING_CST may
+       get virtual operands.
+       (get_expr_operands): Handle STRING_CST like other decls.
+
 2018-08-28  Martin Liska  <mliska@suse.cz>
 
        * tree.h: Update documentation of fndecl_built_in_p

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 6d85561ef839e747dcccb99e90e079bb9c25800e..ddd365ecadef3c22e1ef8163108e1b2e5b62dd77 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2018-08-28  Richard Biener  <rguenther@suse.de>
+
+       PR tree-optimization/87117
+       * gcc.dg/lvalue-5.c: New testcase.
+
 2018-08-27  Jeff Law  <law@redhat.com>
 
        PR tree-optimization/87110

diff --git a/gcc/testsuite/gcc.dg/lvalue-5.c b/gcc/testsuite/gcc.dg/lvalue-5.c
index 514f35ed802bfb860a3f870b268406c033bc1842..ff3598ae8a746f722bd657bff0d7d2874ee4384b 100644 (file)
--- a/gcc/testsuite/gcc.dg/lvalue-5.c
+++ b/gcc/testsuite/gcc.dg/lvalue-5.c
@@ -1,7 +1,7 @@
 /* Test assignment to elements of a string literal is a warning, not
    an error.  PR 27676.  */
 /* { dg-do compile } */
-/* { dg-options "-pedantic-errors" } */
+/* { dg-options "-O -pedantic-errors" } */
 
 void
 f (void)

diff --git a/gcc/tree-ssa-operands.c b/gcc/tree-ssa-operands.c
index eefe270c32d3f8521e6056d9ad63aaee8bff9a60..7bff676cf523fe342c7d524c1e1bf518dd1bbab9 100644 (file)
--- a/gcc/tree-ssa-operands.c
+++ b/gcc/tree-ssa-operands.c
@@ -515,7 +515,7 @@ add_stmt_operand (struct function *fn, tree *var_p, gimple *stmt, int flags)
 {
   tree var = *var_p;
 
-  gcc_assert (SSA_VAR_P (*var_p));
+  gcc_assert (SSA_VAR_P (*var_p) || TREE_CODE (*var_p) == STRING_CST);
 
   if (is_gimple_reg (var))
     {
@@ -740,6 +740,7 @@ get_expr_operands (struct function *fn, gimple *stmt, tree *expr_p, int flags)
     case VAR_DECL:
     case PARM_DECL:
     case RESULT_DECL:
+    case STRING_CST:
       if (!(flags & opf_address_taken))
        add_stmt_operand (fn, expr_p, stmt, flags);
       return;