gdb: remove internalvar_funcs::destroy

No kind of internal var uses it remove it.  This makes the transition to
using a variant easier, since we don't need to think about where this
should be called (in a destructor or not), if it can throw, etc.

Change-Id: Iebbc867d1ce6716480450d9790410d6684cbe4dd

diff --git a/gdb/break-catch-throw.c b/gdb/break-catch-throw.c
index d34e5f9ee53747e6eb3d69a53106b9466d48a0e6..fcd644e6a5f4379dadfb17bec613d9f1f0761f6a 100644 (file)
--- a/gdb/break-catch-throw.c
+++ b/gdb/break-catch-throw.c
@@ -510,7 +510,6 @@ static const struct internalvar_funcs exception_funcs =
 {
   compute_exception,
   NULL,
-  NULL
 };
 
 \f

diff --git a/gdb/inferior.c b/gdb/inferior.c
index 1abdde3b3b483bd202cc0ea9b13317bd704eea64..965ae65287ef665ce0f3ce5017a67ec31bc7e1f4 100644 (file)
--- a/gdb/inferior.c
+++ b/gdb/inferior.c
@@ -982,7 +982,6 @@ static const struct internalvar_funcs inferior_funcs =
 {
   inferior_id_make_value,
   NULL,
-  NULL
 };
 
 \f

diff --git a/gdb/infrun.c b/gdb/infrun.c
index 5311822fcb847f596ca6b29908c577723632066e..85d8404f5b3bf2eac3de228c1d89c1c643b25511 100644 (file)
--- a/gdb/infrun.c
+++ b/gdb/infrun.c
@@ -9368,7 +9368,6 @@ static const struct internalvar_funcs siginfo_funcs =
 {
   siginfo_make_value,
   NULL,
-  NULL
 };
 
 /* Callback for infrun's target events source.  This is marked when a

diff --git a/gdb/probe.c b/gdb/probe.c
index 278b36c3ce845b88cef7196f517efa986d010b12..f0a40f5face1317b41ad06c0ed8b9336e32c08fa 100644 (file)
--- a/gdb/probe.c
+++ b/gdb/probe.c
@@ -866,7 +866,6 @@ static const struct internalvar_funcs probe_funcs =
 {
   compute_probe_arg,
   compile_probe_arg,
-  NULL
 };
 
 

diff --git a/gdb/thread.c b/gdb/thread.c
index 12f3abd57bd5ab0f14e34a7df34346415c11e7b1..9d0693bd0b8ba54aebb05d26429b8ed9199949f1 100644 (file)
--- a/gdb/thread.c
+++ b/gdb/thread.c
@@ -2123,7 +2123,6 @@ static const struct internalvar_funcs thread_funcs =
 {
   thread_id_per_inf_num_make_value,
   NULL,
-  NULL
 };
 
 /* Implementation of `gthread' variable.  */
@@ -2132,7 +2131,6 @@ static const struct internalvar_funcs gthread_funcs =
 {
   global_thread_id_make_value,
   NULL,
-  NULL
 };
 
 void _initialize_thread ();

diff --git a/gdb/tracepoint.c b/gdb/tracepoint.c
index 73ebc38eb805cf61d6a37f25feaf331690456ebd..93868804d586200726f809ae14afb80e24a489cf 100644 (file)
--- a/gdb/tracepoint.c
+++ b/gdb/tracepoint.c
@@ -3985,7 +3985,6 @@ traceframe_available_memory (std::vector<mem_range> *result,
 static const struct internalvar_funcs sdata_funcs =
 {
   sdata_make_value,
-  NULL,
   NULL
 };
 

diff --git a/gdb/value.c b/gdb/value.c
index 76099966f13e83f87718964484984f5d2295f912..080af487c56755882aa0f1df6ae83e6c00cd8912 100644 (file)
--- a/gdb/value.c
+++ b/gdb/value.c
@@ -2449,11 +2449,6 @@ clear_internalvar (struct internalvar *var)
       xfree (var->u.string);
       break;
 
-    case INTERNALVAR_MAKE_VALUE:
-      if (var->u.make_value.functions->destroy != NULL)
-       var->u.make_value.functions->destroy (var->u.make_value.data);
-      break;
-
     default:
       break;
     }

diff --git a/gdb/value.h b/gdb/value.h
index 0de4b5f3aefcd3273238c171e435cfe7103195c6..f7b29022d37cf445cc10807ca79982ff6ec5dfe1 100644 (file)
--- a/gdb/value.h
+++ b/gdb/value.h
@@ -1002,12 +1002,6 @@ struct internalvar_funcs
                         struct agent_expr *expr,
                         struct axs_value *value,
                         void *data);
-
-  /* If non-NULL, this is called to destroy DATA.  The DATA argument
-     passed to this function is the same argument that was passed to
-     `create_internalvar_type_lazy'.  */
-
-  void (*destroy) (void *data);
 };
 
 extern struct internalvar *create_internalvar_type_lazy (const char *name,

diff --git a/gdb/windows-tdep.c b/gdb/windows-tdep.c
index 13be3e4e461d8e309910118351f1cd8901482f2b..91fecd630d7cc6fdb989ec552529ffe163d5fbe9 100644 (file)
--- a/gdb/windows-tdep.c
+++ b/gdb/windows-tdep.c
@@ -970,7 +970,6 @@ static const struct internalvar_funcs tlb_funcs =
 {
   tlb_make_value,
   NULL,
-  NULL
 };
 
 /* Layout of an element of a PE's Import Directory Table.  Based on: