makedevs: don't call /bin/sync after creating nodes
authorPeter Korsgaard <jacmet@sunsite.dk>
Sat, 12 Mar 2011 21:24:34 +0000 (22:24 +0100)
committerPeter Korsgaard <jacmet@sunsite.dk>
Sat, 12 Mar 2011 21:27:06 +0000 (22:27 +0100)
Closes #3475

There's no real reason to sync after creating the device nodes,
and it slows down the file system image creating quite a lot on
busy systems, so get rid of it.

Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
CHANGES
package/makedevs/makedevs.c

diff --git a/CHANGES b/CHANGES
index adc92987af1f7af2f0602b7c95737169d12b9246..eafa2016b4d5eeecd45fde322d1d78be2ab3a47f 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -2,8 +2,12 @@
 
        Updated/fixed packages: avahi, busybox, dropbear, ffmpeg,
        file, gnuconfig, gst-ffmpeg, imagemagick, libdnet, libpng,
-       libxml2, libxslt, mpg123, pkg-config, qt, samba, squashfs,
-       xerces, xorg-server, xz
+       libxml2, libxslt, makedevs, mpg123, pkg-config, qt, samba,
+       squashfs, xerces, xorg-server, xz
+
+       Issues resolved (http://bugs.uclibc.org):
+
+       #3475: Calling sync on large filesystems when not always necessary
 
 2011.02, Released February 28th, 2011:
 
index 79cfc609be58930749d074de3198c1b09cdf6034..9fc71af54d1864bd4447a2022125e1c7ff6d75ab 100644 (file)
@@ -536,8 +536,5 @@ loop:
        }
        fclose(table);
 
-       if (system("/bin/sync"))
-               bb_error_msg("sync failed, continuing anyway");
-
        return 0;
 }