r300: Fix regression: unnecessary node indirection
authorNicolai Haehnle <nhaehnle@gmail.com>
Sun, 25 Mar 2007 11:02:26 +0000 (13:02 +0200)
committerNicolai Haehnle <nhaehnle@gmail.com>
Sun, 25 Mar 2007 11:04:03 +0000 (13:04 +0200)
The texture_rectangle fix introduced a bug where every texture instruction
caused a new indirection.

src/mesa/drivers/dri/r300/r300_fragprog.c

index 68a75ec7f00d1d83e518eb8448c7b2534947d53e..e01f56d99dfdc6be677029ec0aabfa9c4c691b4b 100644 (file)
@@ -934,6 +934,9 @@ static void emit_tex(struct r300_fragment_program *rp,
        int hwsrc, hwdest;
        GLuint tempreg = 0;
 
+       uin = cs->used_in_node;
+       din = cs->dest_in_node;
+
        /* Resolve source/dest to hardware registers */
        if (opcode != R300_FPITX_OP_KIL) {
                if (fpi->TexSrcTarget == TEXTURE_RECT_INDEX) {
@@ -958,6 +961,10 @@ static void emit_tex(struct r300_fragment_program *rp,
                        emit_arith(rp, PFS_OP_MAD, tempreg, WRITEMASK_XYZW,
                                   coord, factorreg, pfs_zero, 0);
 
+                       /* Ensure correct node indirection */
+                       uin = cs->used_in_node;
+                       din = cs->dest_in_node;
+
                        hwsrc = t_hw_src(rp, tempreg, GL_TRUE);
                } else {
                        hwsrc = t_hw_src(rp, coord, GL_TRUE);
@@ -986,8 +993,6 @@ static void emit_tex(struct r300_fragment_program *rp,
                hwsrc = t_hw_src(rp, coord, GL_TRUE);
        }
 
-       din = cs->dest_in_node;
-       uin = cs->used_in_node;
 
        /* Indirection if source has been written in this node, or if the
         * dest has been read/written in this node