st/mesa: fix a regression from cae2bb76
authorFredrik Höglund <fredrik@kde.org>
Thu, 6 Jan 2011 22:12:08 +0000 (23:12 +0100)
committerAlex Deucher <alexdeucher@gmail.com>
Thu, 13 Jan 2011 06:22:20 +0000 (01:22 -0500)
stObj->pt is null when a TFP texture is passed to st_finalize_texture,
and with the changes introduced in the above commit this resulted in a
new texture being created and the existing image being copied into it.

NOTE: This is a candidate for the 7.10 branch.

Reviewed-by: Alex Deucher <alexdeucher@gmail.com>
src/mesa/state_tracker/st_cb_texture.c

index 14d33f7b490c35c501280dacc03b26239a8a4b4f..09a10ba58196d121fb6c48013094043a16b30d82 100644 (file)
@@ -1858,9 +1858,8 @@ st_finalize_texture(struct gl_context *ctx,
     * will match.
     */
    if (firstImage->pt &&
-       stObj->pt &&
        firstImage->pt != stObj->pt &&
-       firstImage->pt->last_level >= stObj->pt->last_level) {
+       (!stObj->pt || firstImage->pt->last_level >= stObj->pt->last_level)) {
       pipe_resource_reference(&stObj->pt, firstImage->pt);
       pipe_sampler_view_reference(&stObj->sampler_view, NULL);
    }