Fix new clang warnings.

2019-08-27  Martin Liska  <mliska@suse.cz>

	* cgraph.c (cgraph_node::remove): Remove dead assignment before
	loop.
	* config/i386/i386-features.c (scalar_chain::emit_conversion_insns):
	Enclose in anonymous namespace.
	* config/i386/x86-tune-costs.h (struct processor_costs): Wrap
	hard_register initialization in braces.
	* tree-vrp.h (value_range_base::supports_type_p): Return false
	for function with boolean return type.

From-SVN: r274945

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 377275745f5b4d9706346df84bc2235ed7ca7cbf..856ce684b79d9821e6d19ded40e386586b56fd45 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,14 @@
+2019-08-27  Martin Liska  <mliska@suse.cz>
+
+       * cgraph.c (cgraph_node::remove): Remove dead assignment before
+       loop.
+       * config/i386/i386-features.c (scalar_chain::emit_conversion_insns):
+       Enclose in anonymous namespace.
+       * config/i386/x86-tune-costs.h (struct processor_costs): Wrap
+       hard_register initialization in braces.
+       * tree-vrp.h (value_range_base::supports_type_p): Return false
+       for function with boolean return type.
+
 2019-08-26  Uroš Bizjak  <ubizjak@gmail.com>
 
        * config/i386/i386.c (emit_i387_cw_initialization)

diff --git a/gcc/cgraph.c b/gcc/cgraph.c
index ea8ab38d8067ca1d584b3d41158b6b4aa81072f5..843891e9e566d74c35b0bb7b91c31f2ebe534913 100644 (file)
--- a/gcc/cgraph.c
+++ b/gcc/cgraph.c
@@ -1783,7 +1783,7 @@ cgraph_node::remove (void)
      */
   force_output = false;
   forced_by_abi = false;
-  cgraph_node *next = nested;
+  cgraph_node *next;
   for (cgraph_node *n = nested; n; n = next)
   {
     next = n->next_nested;

diff --git a/gcc/config/i386/i386-features.c b/gcc/config/i386/i386-features.c
index 8f12bd27aceaec844732820b2edbda0c675add2b..589158475021bafd1b01f9b875cf495796942179 100644 (file)
--- a/gcc/config/i386/i386-features.c
+++ b/gcc/config/i386/i386-features.c
@@ -274,6 +274,8 @@ xlogue_layout::get_stub_rtx (enum xlogue_stub stub)
 
 unsigned scalar_chain::max_id = 0;
 
+namespace {
+
 /* Initialize new chain.  */
 
 scalar_chain::scalar_chain (enum machine_mode smode_, enum machine_mode vmode_)
@@ -622,6 +624,8 @@ scalar_chain::emit_conversion_insns (rtx insns, rtx_insn *after)
   emit_insn_after (insns, BB_HEAD (new_bb));
 }
 
+} // anon namespace
+
 /* Generate the canonical SET_SRC to move GPR to a VMODE vector register,
    zeroing the upper parts.  */
 

diff --git a/gcc/config/i386/x86-tune-costs.h b/gcc/config/i386/x86-tune-costs.h
index ad9ea4bfa089d50ec1b26493ab8c6878f238a776..3381b8bf143c5175b5d3f22b9be272708725f766 100644 (file)
--- a/gcc/config/i386/x86-tune-costs.h
+++ b/gcc/config/i386/x86-tune-costs.h
@@ -36,6 +36,7 @@ static stringop_algs ix86_size_memset[2] = {
 
 const
 struct processor_costs ix86_size_cost = {/* costs for tuning for size */
+  {
   /* Start of register allocator costs.  integer->integer move cost is 2. */
   2,                                /* cost for loading QImode using movzbl */
   {2, 2, 2},                           /* cost of loading integer registers
@@ -59,6 +60,7 @@ struct processor_costs ix86_size_cost = {/* costs for tuning for size */
                                           in 32,64,128,256 and 512-bit */
   3, 3,                                        /* SSE->integer and integer->SSE moves */
   /* End of register allocator costs.  */
+  },
 
   COSTS_N_BYTES (2),                   /* cost of an add instruction */
   COSTS_N_BYTES (3),                   /* cost of a lea instruction */
@@ -138,6 +140,7 @@ static stringop_algs i386_memset[2] = {
 
 static const
 struct processor_costs i386_cost = {   /* 386 specific costs */
+  {
   /* Start of register allocator costs.  integer->integer move cost is 2. */
   4,                                /* cost for loading QImode using movzbl */
   {2, 4, 2},                           /* cost of loading integer registers
@@ -161,6 +164,7 @@ struct processor_costs i386_cost = {        /* 386 specific costs */
                                           in 32,64,128,256 and 512-bit */
   3, 3,                                        /* SSE->integer and integer->SSE moves */
   /* End of register allocator costs.  */
+  },
 
   COSTS_N_INSNS (1),                   /* cost of an add instruction */
   COSTS_N_INSNS (1),                   /* cost of a lea instruction */
@@ -237,6 +241,7 @@ static stringop_algs i486_memset[2] = {
 
 static const
 struct processor_costs i486_cost = {   /* 486 specific costs */
+  {
   /* Start of register allocator costs.  integer->integer move cost is 2. */
   4,                                /* cost for loading QImode using movzbl */
   {2, 4, 2},                           /* cost of loading integer registers
@@ -260,6 +265,7 @@ struct processor_costs i486_cost = {        /* 486 specific costs */
                                           in 32,64,128,256 and 512-bit */
   3, 3,                                        /* SSE->integer and integer->SSE moves */
   /* End of register allocator costs.  */
+  },
 
   COSTS_N_INSNS (1),                   /* cost of an add instruction */
   COSTS_N_INSNS (1),                   /* cost of a lea instruction */
@@ -338,6 +344,7 @@ static stringop_algs pentium_memset[2] = {
 
 static const
 struct processor_costs pentium_cost = {
+  {
   /* Start of register allocator costs.  integer->integer move cost is 2. */
   6,                                /* cost for loading QImode using movzbl */
   {2, 4, 2},                           /* cost of loading integer registers
@@ -361,6 +368,7 @@ struct processor_costs pentium_cost = {
                                           in 32,64,128,256 and 512-bit */
   3, 3,                                        /* SSE->integer and integer->SSE moves */
   /* End of register allocator costs.  */
+  },
 
   COSTS_N_INSNS (1),                   /* cost of an add instruction */
   COSTS_N_INSNS (1),                   /* cost of a lea instruction */
@@ -430,6 +438,7 @@ struct processor_costs pentium_cost = {
 
 static const
 struct processor_costs lakemont_cost = {
+  {
   /* Start of register allocator costs.  integer->integer move cost is 2. */
   6,                                /* cost for loading QImode using movzbl */
   {2, 4, 2},                           /* cost of loading integer registers
@@ -453,6 +462,7 @@ struct processor_costs lakemont_cost = {
                                           in 32,64,128,256 and 512-bit */
   3, 3,                                        /* SSE->integer and integer->SSE moves */
   /* End of register allocator costs.  */
+  },
 
   COSTS_N_INSNS (1),                   /* cost of an add instruction */
   COSTS_N_INSNS (1) + 1,               /* cost of a lea instruction */
@@ -537,6 +547,7 @@ static stringop_algs pentiumpro_memset[2] = {
   DUMMY_STRINGOP_ALGS};
 static const
 struct processor_costs pentiumpro_cost = {
+  {
   /* Start of register allocator costs.  integer->integer move cost is 2. */
   2,                                /* cost for loading QImode using movzbl */
   {4, 4, 4},                           /* cost of loading integer registers
@@ -560,6 +571,7 @@ struct processor_costs pentiumpro_cost = {
                                           in 32,64,128,256 and 512-bit */
   3, 3,                                        /* SSE->integer and integer->SSE moves */
   /* End of register allocator costs.  */
+  },
 
   COSTS_N_INSNS (1),                   /* cost of an add instruction */
   COSTS_N_INSNS (1),                   /* cost of a lea instruction */
@@ -635,6 +647,7 @@ static stringop_algs geode_memset[2] = {
   DUMMY_STRINGOP_ALGS};
 static const
 struct processor_costs geode_cost = {
+  {
   /* Start of register allocator costs.  integer->integer move cost is 2. */
   2,                                /* cost for loading QImode using movzbl */
   {2, 2, 2},                           /* cost of loading integer registers
@@ -658,6 +671,7 @@ struct processor_costs geode_cost = {
                                           in 32,64,128,256 and 512-bit */
   6, 6,                                        /* SSE->integer and integer->SSE moves */
   /* End of register allocator costs.  */
+  },
 
   COSTS_N_INSNS (1),                   /* cost of an add instruction */
   COSTS_N_INSNS (1),                   /* cost of a lea instruction */
@@ -733,6 +747,7 @@ static stringop_algs k6_memset[2] = {
   DUMMY_STRINGOP_ALGS};
 static const
 struct processor_costs k6_cost = {
+  {
   /* Start of register allocator costs.  integer->integer move cost is 2. */
   3,                                /* cost for loading QImode using movzbl */
   {4, 5, 4},                           /* cost of loading integer registers
@@ -756,6 +771,7 @@ struct processor_costs k6_cost = {
                                           in 32,64,128,256 and 512-bit */
   6, 6,                                        /* SSE->integer and integer->SSE moves */
   /* End of register allocator costs.  */
+  },
 
   COSTS_N_INSNS (1),                   /* cost of an add instruction */
   COSTS_N_INSNS (2),                   /* cost of a lea instruction */
@@ -837,6 +853,7 @@ static stringop_algs athlon_memset[2] = {
   DUMMY_STRINGOP_ALGS};
 static const
 struct processor_costs athlon_cost = {
+  {
   /* Start of register allocator costs.  integer->integer move cost is 2. */
   4,                                /* cost for loading QImode using movzbl */
   {3, 4, 3},                           /* cost of loading integer registers
@@ -860,6 +877,7 @@ struct processor_costs athlon_cost = {
                                           in 32,64,128,256 and 512-bit */
   5, 5,                                        /* SSE->integer and integer->SSE moves */
   /* End of register allocator costs.  */
+  },
 
   COSTS_N_INSNS (1),                   /* cost of an add instruction */
   COSTS_N_INSNS (2),                   /* cost of a lea instruction */
@@ -943,6 +961,7 @@ static stringop_algs k8_memset[2] = {
              {8192, rep_prefix_8_byte, false}, {-1, libcall, false}}}};
 static const
 struct processor_costs k8_cost = {
+  {
   /* Start of register allocator costs.  integer->integer move cost is 2. */
   4,                                /* cost for loading QImode using movzbl */
   {3, 4, 3},                           /* cost of loading integer registers
@@ -966,6 +985,7 @@ struct processor_costs k8_cost = {
                                           in 32,64,128,256 and 512-bit */
   5, 5,                                        /* SSE->integer and integer->SSE moves */
   /* End of register allocator costs.  */
+  },
 
   COSTS_N_INSNS (1),                   /* cost of an add instruction */
   COSTS_N_INSNS (2),                   /* cost of a lea instruction */
@@ -1053,6 +1073,7 @@ static stringop_algs amdfam10_memset[2] = {
   {libcall, {{48, unrolled_loop, false}, {8192, rep_prefix_8_byte, false},
              {-1, libcall, false}}}};
 struct processor_costs amdfam10_cost = {
+  {
   /* Start of register allocator costs.  integer->integer move cost is 2. */
   4,                                /* cost for loading QImode using movzbl */
   {3, 4, 3},                           /* cost of loading integer registers
@@ -1085,6 +1106,7 @@ struct processor_costs amdfam10_cost = {
                                            MOVD reg32, xmmreg Double FADD 3
                                                               1/1  1/1 */
   /* End of register allocator costs.  */
+  },
 
   COSTS_N_INSNS (1),                   /* cost of an add instruction */
   COSTS_N_INSNS (2),                   /* cost of a lea instruction */
@@ -1173,6 +1195,7 @@ static stringop_algs bdver_memset[2] = {
              {-1, libcall, false}}}};
 
 const struct processor_costs bdver_cost = {
+  {
   /* Start of register allocator costs.  integer->integer move cost is 2. */
   8,                                /* cost for loading QImode using movzbl */
   {8, 8, 8},                           /* cost of loading integer registers
@@ -1196,6 +1219,7 @@ const struct processor_costs bdver_cost = {
                                           in 32,64,128,256 and 512-bit */
   16, 20,                              /* SSE->integer and integer->SSE moves */
   /* End of register allocator costs.  */
+  },
 
   COSTS_N_INSNS (1),                   /* cost of an add instruction */
   COSTS_N_INSNS (1),                   /* cost of a lea instruction */
@@ -1285,6 +1309,7 @@ static stringop_algs znver1_memset[2] = {
   {libcall, {{48, unrolled_loop, false}, {8192, rep_prefix_8_byte, false},
             {-1, libcall, false}}}};
 struct processor_costs znver1_cost = {
+  {
   /* Start of register allocator costs.  integer->integer move cost is 2. */
 
   /* reg-reg moves are done by renaming and thus they are even cheaper than
@@ -1315,6 +1340,7 @@ struct processor_costs znver1_cost = {
                                           in 32,64,128,256 and 512-bit.  */
   6, 6,                                        /* SSE->integer and integer->SSE moves.  */
   /* End of register allocator costs.  */
+  },
 
   COSTS_N_INSNS (1),                   /* cost of an add instruction.  */
   COSTS_N_INSNS (1),                   /* cost of a lea instruction.  */
@@ -1420,6 +1446,7 @@ static stringop_algs znver2_memset[2] = {
             {-1, libcall, false}}}};
 
 struct processor_costs znver2_cost = {
+  {
   /* Start of register allocator costs.  integer->integer move cost is 2. */
 
   /* reg-reg moves are done by renaming and thus they are even cheaper than
@@ -1452,6 +1479,7 @@ struct processor_costs znver2_cost = {
   6, 6,                                        /* SSE->integer and integer->SSE
                                           moves.  */
   /* End of register allocator costs.  */
+  },
 
   COSTS_N_INSNS (1),                   /* cost of an add instruction.  */
   COSTS_N_INSNS (1),                   /* cost of a lea instruction.  */
@@ -1560,6 +1588,7 @@ static stringop_algs skylake_memset[2] = {
 
 static const
 struct processor_costs skylake_cost = {
+  {
   /* Start of register allocator costs.  integer->integer move cost is 2. */
   6,                                /* cost for loading QImode using movzbl */
   {4, 4, 4},                           /* cost of loading integer registers
@@ -1583,6 +1612,7 @@ struct processor_costs skylake_cost = {
                                           in 32,64,128,256 and 512-bit */
   2, 2,                                        /* SSE->integer and integer->SSE moves */
   /* End of register allocator costs.  */
+  },
 
   COSTS_N_INSNS (1),                   /* cost of an add instruction */
   COSTS_N_INSNS (1)+1,         /* cost of a lea instruction */
@@ -1665,6 +1695,7 @@ static stringop_algs btver1_memset[2] = {
   {libcall, {{48, unrolled_loop, false}, {8192, rep_prefix_8_byte, false},
              {-1, libcall, false}}}};
 const struct processor_costs btver1_cost = {
+  {
   /* Start of register allocator costs.  integer->integer move cost is 2. */
   8,                                /* cost for loading QImode using movzbl */
   {6, 8, 6},                           /* cost of loading integer registers
@@ -1688,6 +1719,7 @@ const struct processor_costs btver1_cost = {
                                           in 32,64,128,256 and 512-bit */
   14, 14,                              /* SSE->integer and integer->SSE moves */
   /* End of register allocator costs.  */
+  },
 
   COSTS_N_INSNS (1),                   /* cost of an add instruction */
   COSTS_N_INSNS (2),                   /* cost of a lea instruction */
@@ -1766,6 +1798,7 @@ static stringop_algs btver2_memset[2] = {
   {libcall, {{48, unrolled_loop, false}, {8192, rep_prefix_8_byte, false},
              {-1, libcall, false}}}};
 const struct processor_costs btver2_cost = {
+  {
   /* Start of register allocator costs.  integer->integer move cost is 2. */
   8,                                /* cost for loading QImode using movzbl */
   {8, 8, 6},                           /* cost of loading integer registers
@@ -1789,6 +1822,7 @@ const struct processor_costs btver2_cost = {
                                           in 32,64,128,256 and 512-bit */
   14, 14,                              /* SSE->integer and integer->SSE moves */
   /* End of register allocator costs.  */
+  },
 
   COSTS_N_INSNS (1),                   /* cost of an add instruction */
   COSTS_N_INSNS (2),                   /* cost of a lea instruction */
@@ -1866,6 +1900,7 @@ static stringop_algs pentium4_memset[2] = {
 
 static const
 struct processor_costs pentium4_cost = {
+  {
   /* Start of register allocator costs.  integer->integer move cost is 2. */
   5,                                /* cost for loading QImode using movzbl */
   {4, 5, 4},                           /* cost of loading integer registers
@@ -1889,6 +1924,7 @@ struct processor_costs pentium4_cost = {
                                           in 32,64,128,256 and 512-bit */
   20, 12,                              /* SSE->integer and integer->SSE moves */
   /* End of register allocator costs.  */
+  },
 
   COSTS_N_INSNS (1),                   /* cost of an add instruction */
   COSTS_N_INSNS (3),                   /* cost of a lea instruction */
@@ -1969,6 +2005,7 @@ static stringop_algs nocona_memset[2] = {
 
 static const
 struct processor_costs nocona_cost = {
+  {
   /* Start of register allocator costs.  integer->integer move cost is 2. */
   4,                                /* cost for loading QImode using movzbl */
   {4, 4, 4},                           /* cost of loading integer registers
@@ -1992,6 +2029,7 @@ struct processor_costs nocona_cost = {
                                           in 32,64,128,256 and 512-bit */
   20, 12,                              /* SSE->integer and integer->SSE moves */
   /* End of register allocator costs.  */
+  },
 
   COSTS_N_INSNS (1),                   /* cost of an add instruction */
   COSTS_N_INSNS (1),                   /* cost of a lea instruction */
@@ -2070,6 +2108,7 @@ static stringop_algs atom_memset[2] = {
              {8192, rep_prefix_8_byte, false}, {-1, libcall, false}}}};
 static const
 struct processor_costs atom_cost = {
+  {
   /* Start of register allocator costs.  integer->integer move cost is 2. */
   6,                                   /* cost for loading QImode using movzbl */
   {6, 6, 6},                           /* cost of loading integer registers
@@ -2093,6 +2132,7 @@ struct processor_costs atom_cost = {
                                           in 32,64,128,256 and 512-bit */
   8, 6,                                        /* SSE->integer and integer->SSE moves */
   /* End of register allocator costs.  */
+  },
 
   COSTS_N_INSNS (1),                   /* cost of an add instruction */
   COSTS_N_INSNS (1) + 1,               /* cost of a lea instruction */
@@ -2171,6 +2211,7 @@ static stringop_algs slm_memset[2] = {
              {8192, rep_prefix_8_byte, false}, {-1, libcall, false}}}};
 static const
 struct processor_costs slm_cost = {
+  {
   /* Start of register allocator costs.  integer->integer move cost is 2. */
   8,                                   /* cost for loading QImode using movzbl */
   {8, 8, 8},                           /* cost of loading integer registers
@@ -2194,6 +2235,7 @@ struct processor_costs slm_cost = {
                                           in 32,64,128,256 and 512-bit */
   8, 6,                                        /* SSE->integer and integer->SSE moves */
   /* End of register allocator costs.  */
+  },
 
   COSTS_N_INSNS (1),                   /* cost of an add instruction */
   COSTS_N_INSNS (1) + 1,               /* cost of a lea instruction */
@@ -2272,6 +2314,7 @@ static stringop_algs intel_memset[2] = {
              {8192, rep_prefix_8_byte, false}, {-1, libcall, false}}}};
 static const
 struct processor_costs intel_cost = {
+  {
   /* Start of register allocator costs.  integer->integer move cost is 2. */
   6,                                /* cost for loading QImode using movzbl */
   {4, 4, 4},                           /* cost of loading integer registers
@@ -2295,6 +2338,7 @@ struct processor_costs intel_cost = {
                                           in 32,64,128,256 and 512-bit */
   4, 4,                                        /* SSE->integer and integer->SSE moves */
   /* End of register allocator costs.  */
+  },
 
   COSTS_N_INSNS (1),                   /* cost of an add instruction */
   COSTS_N_INSNS (1) + 1,               /* cost of a lea instruction */
@@ -2377,6 +2421,7 @@ static stringop_algs generic_memset[2] = {
              {-1, libcall, false}}}};
 static const
 struct processor_costs generic_cost = {
+  {
   /* Start of register allocator costs.  integer->integer move cost is 2. */
   6,                                /* cost for loading QImode using movzbl */
   {6, 6, 6},                           /* cost of loading integer registers
@@ -2400,6 +2445,7 @@ struct processor_costs generic_cost = {
                                           in 32,64,128,256 and 512-bit */
   6, 6,                                        /* SSE->integer and integer->SSE moves */
   /* End of register allocator costs.  */
+  },
 
   COSTS_N_INSNS (1),                   /* cost of an add instruction */
   /* Setting cost to 2 makes our current implementation of synth_mult result in
@@ -2487,6 +2533,7 @@ static stringop_algs core_memset[2] = {
 
 static const
 struct processor_costs core_cost = {
+  {
   /* Start of register allocator costs.  integer->integer move cost is 2. */
   6,                                /* cost for loading QImode using movzbl */
   {4, 4, 4},                           /* cost of loading integer registers
@@ -2510,6 +2557,7 @@ struct processor_costs core_cost = {
                                           in 32,64,128,256 and 512-bit */
   2, 2,                                        /* SSE->integer and integer->SSE moves */
   /* End of register allocator costs.  */
+  },
 
   COSTS_N_INSNS (1),                   /* cost of an add instruction */
   /* On all chips taken into consideration lea is 2 cycles and more.  With

diff --git a/gcc/tree-vrp.h b/gcc/tree-vrp.h
index c879a8c6df87fbd8c0914129778c201b71097586..cf236fa6264ab5491619dea801b61884e703f9f4 100644 (file)
--- a/gcc/tree-vrp.h
+++ b/gcc/tree-vrp.h
@@ -265,7 +265,7 @@ value_range_base::supports_type_p (tree type)
 {
   if (type && (INTEGRAL_TYPE_P (type) || POINTER_TYPE_P (type)))
     return type;
-  return NULL;
+  return false;
 }
 
 extern void register_edge_assert_for (tree, edge, enum tree_code,