Fix use-after-move bug in add_thread_object

commit 05b08ac1608 ("Reduce manual reference counting in
py-inferior.c") introduced a use-after-move bug in add_thread_object,
causing a test suite failure.  This patch fixes the bug.

Tested on x86-64 Fedora 29.

gdb/ChangeLog
2019-07-11  Tom Tromey  <tromey@adacore.com>

	* python/py-inferior.c (add_thread_object): Don't use thread_obj
	after it has been moved.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 49ccba76f14966dc4e1295f173b1759f20930bbf..b5585b4085a284b73a3b9640012579cd1c1f1e34 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2019-07-11  Tom Tromey  <tromey@adacore.com>
+
+       * python/py-inferior.c (add_thread_object): Don't use thread_obj
+       after it has been moved.
+
 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 
        * valops.c (value_must_coerce_to_target): Change return type to

diff --git a/gdb/python/py-inferior.c b/gdb/python/py-inferior.c
index bf43012352bc047359a998468752b19b51de2046..28882221a90756903b5c20fd4609284273522bcf 100644 (file)
--- a/gdb/python/py-inferior.c
+++ b/gdb/python/py-inferior.c
@@ -344,7 +344,7 @@ add_thread_object (struct thread_info *tp)
     return;
 
   gdbpy_ref<> event = create_thread_event_object (&new_thread_event_object_type,
-                                                 (PyObject *) thread_obj.get ());
+                                                 (PyObject *) inf_obj);
   if (event == NULL
       || evpy_emit_event (event.get (), gdb_py_events.new_thread) < 0)
     gdbpy_print_stack ();