linux-record: Squash cases with identical handling
authorAndreas Arnez <arnez@linux.vnet.ibm.com>
Tue, 19 Apr 2016 14:53:40 +0000 (16:53 +0200)
committerAndreas Arnez <arnez@linux.vnet.ibm.com>
Tue, 19 Apr 2016 14:53:40 +0000 (16:53 +0200)
In record_linux_system_call there are some cases with identical
handling.  These are merged together to reduce code duplication.

gdb/ChangeLog:

* linux-record.c (record_linux_system_call): Merge handling for
readlink/recv/read and pipe/pipe2.

gdb/ChangeLog
gdb/linux-record.c

index 1b12330f28bf624a22e39e2fcb4303ef17c0f04c..4dee49095c519484b0810e7dade263533850b27f 100644 (file)
@@ -1,3 +1,8 @@
+2016-04-19  Andreas Arnez  <arnez@linux.vnet.ibm.com>
+
+       * linux-record.c (record_linux_system_call): Merge handling for
+       readlink/recv/read and pipe/pipe2.
+
 2016-04-14  Walfred Tedeschi  <walfred.tedeschi@intel.com>
 
        * features/i386/amd64-mpx-linux.xml: Remove AVX feature.
index fda7ada5499ec125a3836ec38c2955a0bf341aa1..51253ccf7785dd992f0052339f6715a2bfc93397 100644 (file)
@@ -264,6 +264,8 @@ record_linux_system_call (enum gdb_syscall syscall,
       break;
 
     case gdb_sys_read:
+    case gdb_sys_readlink:
+    case gdb_sys_recv:
       regcache_raw_read_unsigned (regcache, tdep->arg3, &tmpulongest);
       if (record_mem_at_reg (regcache, tdep->arg2, (int) tmpulongest))
        return -1;
@@ -348,6 +350,7 @@ record_linux_system_call (enum gdb_syscall syscall,
       break;
 
     case gdb_sys_pipe:
+    case gdb_sys_pipe2:
       if (record_mem_at_reg (regcache, tdep->arg1, tdep->size_int * 2))
        return -1;
       break;
@@ -645,12 +648,6 @@ record_linux_system_call (enum gdb_syscall syscall,
     case gdb_sys_symlink:
       break;
 
-    case gdb_sys_readlink:
-      regcache_raw_read_unsigned (regcache, tdep->arg3, &tmpulongest);
-      if (record_mem_at_reg (regcache, tdep->arg2, (int) tmpulongest))
-       return -1;
-      break;
-
     case gdb_sys_uselib:
     case gdb_sys_swapon:
       break;
@@ -742,12 +739,6 @@ Do you want to stop the program?"),
       }
       break;
 
-    case gdb_sys_recv:
-      regcache_raw_read_unsigned (regcache, tdep->arg3, &tmpulongest);
-      if (record_mem_at_reg (regcache, tdep->arg2, (int) tmpulongest))
-       return -1;
-      break;
-
     case gdb_sys_recvmsg:
       regcache_raw_read_unsigned (regcache, tdep->arg2, &tmpulongest);
       if (record_linux_msghdr (regcache, tdep, tmpulongest))
@@ -2035,11 +2026,6 @@ Do you want to stop the program?"),
     case gdb_sys_dup3:
       break;
 
-    case gdb_sys_pipe2:
-      if (record_mem_at_reg (regcache, tdep->arg1, tdep->size_int * 2))
-       return -1;
-      break;
-
     case gdb_sys_inotify_init1:
       break;