etnaviv: add missing fallthrough comments
authorTimothy Arceri <tarceri@itsqueeze.com>
Wed, 8 Jul 2020 09:31:21 +0000 (19:31 +1000)
committerMarge Bot <eric+marge@anholt.net>
Fri, 10 Jul 2020 00:32:51 +0000 (00:32 +0000)
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5799>

src/gallium/drivers/etnaviv/etnaviv_clear_blit.c
src/gallium/drivers/etnaviv/etnaviv_compiler_nir.c
src/gallium/drivers/etnaviv/etnaviv_compiler_nir.h
src/gallium/drivers/etnaviv/etnaviv_format.c

index b878dc976abe8498f4f3a0d6c92b8cceb79bc746..3ccfc6747b3961f996b691097dd25486cc3a62c8 100644 (file)
@@ -78,10 +78,13 @@ etna_clear_blit_pack_rgba(enum pipe_format format, const union pipe_color_union
    switch (util_format_get_blocksize(format)) {
    case 1:
       uc.ui[0] = uc.ui[0] << 8 | (uc.ui[0] & 0xff);
+      /* fallthrough */
    case 2:
       uc.ui[0] =  uc.ui[0] << 16 | (uc.ui[0] & 0xffff);
+      /* fallthrough */
    case 4:
       uc.ui[1] = uc.ui[0];
+      /* fallthrough */
    default:
       return (uint64_t) uc.ui[1] << 32 | uc.ui[0];
    }
index 63b5152a4a614c9341961ef7cf7fe3e3eca0364c..44e6c5ec9d5de2c6e37a93fd61802dda27224b53 100644 (file)
@@ -852,6 +852,7 @@ lower_alu(struct etna_compile *c, nir_alu_instr *alu)
             need_mov = vec_dest_has_swizzle(alu, &nir_instr_as_intrinsic(instr)->dest.ssa);
             break;
          }
+         /* fallthrough */
       default:
          need_mov = true;
       }
index 4808767b64093d8f42a77e26e122e95a81431f4c..7a2bbdf70a14480ed886199ef874605632807926 100644 (file)
@@ -145,6 +145,7 @@ real_dest(nir_dest *dest, unsigned *swiz, unsigned *mask)
              nir_instr_as_alu(p_instr)->op == nir_op_mov) {
             break;
          }
+         /* fallthrough */
       default:
          can_bypass_src = false;
          break;
index 97df90e065d8cdf06145fbdd61307ab38057ecbd..598e61b5d5dbe0c2683cd90f261809414d0e8c7d 100644 (file)
@@ -277,6 +277,7 @@ texture_use_int_filter(const struct pipe_sampler_view *sv,
    case PIPE_TEXTURE_2D_ARRAY:
       if (tex_desc)
          break;
+      /* fallthrough */
    case PIPE_TEXTURE_3D:
       return false;
    default: