Get simple cpu to compile.

Now I need to fix linking errors, probably due to missing function details in new memory objects.

cpu/exec_context.cc:
cpu/exec_context.hh:
    Fix constructor for SE mode
cpu/simple/cpu.cc:
cpu/simple/cpu.hh:
    Fix compilation errors

--HG--
extra : convert_revision : 6a58c0906340e10b654369c36f528fc17e3f19be

diff --git a/cpu/exec_context.cc b/cpu/exec_context.cc
index 10894230b84f47e8347d7fabe0f021ab910956ab..fa91eb67230370f64241c2bd569a753799041808 100644 (file)
--- a/cpu/exec_context.cc
+++ b/cpu/exec_context.cc
@@ -77,11 +77,10 @@ ExecContext::ExecContext(BaseCPU *_cpu, int _thread_num, System *_sys,
     profilePC = 3;
 }
 #else
-ExecContext::ExecContext(BaseCPU *_cpu, int _thread_num, System *_system,
-                         Memory *_mem, Process *_process, int _asid)
+ExecContext::ExecContext(BaseCPU *_cpu, int _thread_num,
+                         Process *_process, int _asid)
     : _status(ExecContext::Unallocated),
       cpu(_cpu), thread_num(_thread_num), cpu_id(-1),
-      system(_system),
       process(_process),
       asid(_asid),
       func_exe_inst(0), storeCondFailures(0)

diff --git a/cpu/exec_context.hh b/cpu/exec_context.hh
index 3d40c06f0f7ed47ee12c7d3e3ad73b4c6a5252c0..8e9e5f2fd17303414e4967d3138461090a8c3ea9 100644 (file)
--- a/cpu/exec_context.hh
+++ b/cpu/exec_context.hh
@@ -186,8 +186,8 @@ class ExecContext
     ExecContext(BaseCPU *_cpu, int _thread_num, System *_system,
                 AlphaITB *_itb, AlphaDTB *_dtb, FunctionalMemory *_dem);
 #else
-    ExecContext(BaseCPU *_cpu, int _thread_num, System *_system,
-                Memory *_mem, Process *_process, int _asid);
+    ExecContext(BaseCPU *_cpu, int _thread_num,
+                Process *_process, int _asid);
 #endif
     virtual ~ExecContext();
 

diff --git a/cpu/simple/cpu.cc b/cpu/simple/cpu.cc
index 7f589548d12fe988a843ad83876a83060e1f5d24..4937e5debd408338731fad80cec427e8ab838199 100644 (file)
--- a/cpu/simple/cpu.cc
+++ b/cpu/simple/cpu.cc
@@ -52,8 +52,6 @@
 #include "cpu/smt.hh"
 #include "cpu/static_inst.hh"
 #include "kern/kernel_stats.hh"
-#include "mem/base_mem.hh"
-#include "mem/mem_interface.hh"
 #include "sim/builder.hh"
 #include "sim/debug.hh"
 #include "sim/host.hh"
@@ -70,7 +68,7 @@
 #include "targetarch/stacktrace.hh"
 #include "targetarch/vtophys.hh"
 #else // !FULL_SYSTEM
-#include "mem/functional/functional.hh"
+#include "mem/memory.hh"
 #endif // FULL_SYSTEM
 
 using namespace std;
@@ -97,12 +95,6 @@ SimpleCPU::TickEvent::description()
 }
 
 
-SimpleCPU::CacheCompletionEvent::CacheCompletionEvent(SimpleCPU *_cpu)
-    : Event(&mainEventQueue), cpu(_cpu)
-{
-}
-
-
 bool
 SimpleCPU::CpuPort::recvTiming(Packet &pkt)
 {
@@ -139,8 +131,8 @@ SimpleCPU::CpuPort::recvRetry()
 
 
 SimpleCPU::SimpleCPU(Params *p)
-    : BaseCPU(p), tickEvent(this, p->width), xc(NULL),
-      cacheCompletionEvent(this), dcachePort(this), icachePort(this)
+    : BaseCPU(p), icachePort(this),
+      dcachePort(this), tickEvent(this, p->width), xc(NULL)
 {
     _status = Idle;
 #if FULL_SYSTEM
@@ -152,7 +144,7 @@ SimpleCPU::SimpleCPU(Params *p)
     xc = new ExecContext(this, /* thread_num */ 0, p->process, /* asid */ 0);
 #endif // !FULL_SYSTEM
 
-    xc->memPort = dcachePort;
+    memPort = &dcachePort;
 
     req = new CpuRequest;
 
@@ -324,7 +316,6 @@ SimpleCPU::serialize(ostream &os)
     nameOut(os, csprintf("%s.tickEvent", name()));
     tickEvent.serialize(os);
     nameOut(os, csprintf("%s.cacheCompletionEvent", name()));
-    cacheCompletionEvent.serialize(os);
 }
 
 void
@@ -335,8 +326,6 @@ SimpleCPU::unserialize(Checkpoint *cp, const string &section)
     UNSERIALIZE_SCALAR(inst);
     xc->unserialize(cp, csprintf("%s.xc", section));
     tickEvent.unserialize(cp, csprintf("%s.tickEvent", section));
-    cacheCompletionEvent
-        .unserialize(cp, csprintf("%s.cacheCompletionEvent", section));
 }
 
 void
@@ -365,7 +354,7 @@ SimpleCPU::copySrcTranslate(Addr src)
     memReq->reset(src & ~(blk_size - 1), blk_size);
 
     // translate to physical address
-    Fault fault = xc->translateDataReadReq(memReq);
+    Fault fault = xc->translateDataReadReq(req);
 
     assert(fault != Alignment_Fault);
 
@@ -378,7 +367,7 @@ SimpleCPU::copySrcTranslate(Addr src)
     }
     return fault;
 #else
-    return No_Fault
+    return No_Fault;
 #endif
 }
 
@@ -404,7 +393,7 @@ SimpleCPU::copy(Addr dest)
 
     memReq->reset(dest & ~(blk_size -1), blk_size);
     // translate to physical address
-    Fault fault = xc->translateDataWriteReq(memReq);
+    Fault fault = xc->translateDataWriteReq(req);
 
     assert(fault != Alignment_Fault);
 
@@ -456,7 +445,7 @@ SimpleCPU::read(Addr addr, T &data, unsigned flags)
 
     // translate to physical address
     // NEED NEW TRANSLATION HERE
-    Fault fault = xc->translateDataReadReq(memReq);
+    Fault fault = xc->translateDataReadReq(req);
 
     // Now do the access.
     if (fault == No_Fault) {
@@ -496,7 +485,7 @@ SimpleCPU::read(Addr addr, T &data, unsigned flags)
     }
 */
     // This will need a new way to tell if it has a dcache attached.
-    if (/*!dcacheInterface && */(memReq->flags & UNCACHEABLE))
+    if (/*!dcacheInterface && */(req->flags & UNCACHEABLE))
         recordEvent("Uncached Read");
 
     return fault;
@@ -556,7 +545,7 @@ SimpleCPU::write(T data, Addr addr, unsigned flags, uint64_t *res)
 
     // translate to physical address
     // NEED NEW TRANSLATION HERE
-    Fault fault = xc->translateDataWriteReq(memReq);
+    Fault fault = xc->translateDataWriteReq(req);
 
     // Now do the access.
     if (fault == No_Fault) {
@@ -597,10 +586,10 @@ SimpleCPU::write(T data, Addr addr, unsigned flags, uint64_t *res)
     }
 */
     if (res && (fault == No_Fault))
-        *res = memReq->result;
+        *res = pkt->result;
 
     // This will need a new way to tell if it's hooked up to a cache or not.
-    if (/*!dcacheInterface && */(memReq->flags & UNCACHEABLE))
+    if (/*!dcacheInterface && */(req->flags & UNCACHEABLE))
         recordEvent("Uncached Write");
 
     // If the write needs to have a fault on the access, consider calling
@@ -663,7 +652,7 @@ void
 SimpleCPU::sendIcacheRequest()
 {
 #if 1
-    bool success = icachePort.sendTiming(pkt);
+    bool success = icachePort.sendTiming(*pkt);
 
     unscheduleTickEvent();
 
@@ -697,7 +686,7 @@ SimpleCPU::sendDcacheRequest()
     unscheduleTickEvent();
 
 #if 1
-    bool success = dcachePort.sendTiming(pkt);
+    bool success = dcachePort.sendTiming(*pkt);
 
     lastDcacheStall = curTick;
 
@@ -722,12 +711,12 @@ SimpleCPU::sendDcacheRequest()
 }
 
 void
-SimpleCPU::processResponse(Packet *response)
+SimpleCPU::processResponse(Packet &response)
 {
     // For what things is the CPU the consumer of the packet it sent
     // out?  This may create a memory leak if that's the case and it's
     // expected of the SimpleCPU to delete its own packet.
-    pkt = response;
+    pkt = &response;
 
     switch (status()) {
       case IcacheWaitResponse:
@@ -742,7 +731,7 @@ SimpleCPU::processResponse(Packet *response)
         delete pkt;
         break;
       case DcacheWaitResponse:
-        if (req->cmd.isRead()) {
+        if (pkt->cmd == Read) {
             curStaticInst->execute(this,traceData);
             if (traceData)
                 traceData->finalize();
@@ -755,7 +744,7 @@ SimpleCPU::processResponse(Packet *response)
         scheduleTickEvent(1);
         break;
       case DcacheWaitSwitch:
-        if (memReq->cmd.isRead()) {
+        if (pkt->cmd == Read) {
             curStaticInst->execute(this,traceData);
             if (traceData)
                 traceData->finalize();
@@ -893,7 +882,7 @@ SimpleCPU::tick()
                      IFETCH_FLAGS(xc->regs.pc));
 */
 //NEED NEW TRANSLATION HERE
-        fault = xc->translateInstReq(memReq);
+        fault = xc->translateInstReq(req);
 
         if (fault == No_Fault) {
             pkt = new Packet;
@@ -980,7 +969,7 @@ SimpleCPU::tick()
         // If we have a dcache miss, then we can't finialize the instruction
         // trace yet because we want to populate it with the data later
         if (traceData &&
-                !(status() == DcacheWaitResponse && memReq->cmd.isRead())) {
+                !(status() == DcacheWaitResponse && pkt->cmd == Read)) {
             traceData->finalize();
         }
 
@@ -1040,8 +1029,6 @@ BEGIN_DECLARE_SIM_OBJECT_PARAMS(SimpleCPU)
 #endif // FULL_SYSTEM
 
     Param<int> clock;
-    SimObjectParam<BaseMem *> icache;
-    SimObjectParam<BaseMem *> dcache;
 
     Param<bool> defer_registration;
     Param<int> width;
@@ -1073,8 +1060,6 @@ BEGIN_INIT_SIM_OBJECT_PARAMS(SimpleCPU)
 #endif // FULL_SYSTEM
 
     INIT_PARAM(clock, "clock speed"),
-    INIT_PARAM(icache, "L1 instruction cache object"),
-    INIT_PARAM(dcache, "L1 data cache object"),
     INIT_PARAM(defer_registration, "defer system registration (for sampling)"),
     INIT_PARAM(width, "cpu width"),
     INIT_PARAM(function_trace, "Enable function trace"),
@@ -1096,8 +1081,6 @@ CREATE_SIM_OBJECT(SimpleCPU)
     params->clock = clock;
     params->functionTrace = function_trace;
     params->functionTraceStart = function_trace_start;
-    params->icache_interface = (icache) ? icache->getInterface() : NULL;
-    params->dcache_interface = (dcache) ? dcache->getInterface() : NULL;
     params->width = width;
 
 #if FULL_SYSTEM

diff --git a/cpu/simple/cpu.hh b/cpu/simple/cpu.hh
index 3d445b001e97dae8bd4659d61e708e185d87ed55..6df553fe21b5c97eef1163b0c52c3d8e22435205 100644 (file)
--- a/cpu/simple/cpu.hh
+++ b/cpu/simple/cpu.hh
@@ -248,7 +248,10 @@ class SimpleCPU : public BaseCPU
 
     void sendIcacheRequest();
     void sendDcacheRequest();
-    void processResponse(Packet *response);
+    void processResponse(Packet &response);
+
+    Packet * processRetry();
+    void recvStatusChange(Port::Status status) {}
 
     virtual void serialize(std::ostream &os);
     virtual void unserialize(Checkpoint *cp, const std::string &section);