r300: add and fix up fallthrough comments
authorTimothy Arceri <tarceri@itsqueeze.com>
Wed, 1 Jul 2020 06:35:44 +0000 (16:35 +1000)
committerMarge Bot <eric+marge@anholt.net>
Thu, 2 Jul 2020 23:52:53 +0000 (23:52 +0000)
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5705>

src/gallium/drivers/r300/r300_emit.c
src/gallium/drivers/r300/r300_state_derived.c
src/gallium/drivers/r300/r300_texture.c

index dc33aea95c2ce4602aca54979640d63a3dea586c..fed3f71e5dac4a0738d021997ba43fbbbd1f553c 100644 (file)
@@ -686,11 +686,13 @@ static void r300_emit_query_end_frag_pipes(struct r300_context *r300,
             OUT_CS_REG(R300_SU_REG_DEST, 1 << 3);
             OUT_CS_REG(R300_ZB_ZPASS_ADDR, (query->num_results + 3) * 4);
             OUT_CS_RELOC(r300->query_current);
+            /* fallthrough */
         case 3:
             /* pipe 2 only */
             OUT_CS_REG(R300_SU_REG_DEST, 1 << 2);
             OUT_CS_REG(R300_ZB_ZPASS_ADDR, (query->num_results + 2) * 4);
             OUT_CS_RELOC(r300->query_current);
+            /* fallthrough */
         case 2:
             /* pipe 1 only */
             /* As mentioned above, accommodate RV380 and older. */
@@ -698,6 +700,7 @@ static void r300_emit_query_end_frag_pipes(struct r300_context *r300,
                     1 << (caps->high_second_pipe ? 3 : 1));
             OUT_CS_REG(R300_ZB_ZPASS_ADDR, (query->num_results + 1) * 4);
             OUT_CS_RELOC(r300->query_current);
+            /* fallthrough */
         case 1:
             /* pipe 0 only */
             OUT_CS_REG(R300_SU_REG_DEST, 1 << 0);
index 848bbd392bcfcae740485692435ab221b8cfee8b..150fafe88be6c14afa40a2f5bf357b469c0b0757 100644 (file)
@@ -683,7 +683,7 @@ static uint32_t r300_get_border_color(enum pipe_format format,
             border_swizzled[0] = border_swizzled[0] < 0 ?
                                  border_swizzled[0]*0.5+1 :
                                  border_swizzled[0]*0.5;
-            /* Pass through. */
+            /* fallthrough. */
 
         case PIPE_FORMAT_RGTC1_UNORM:
         case PIPE_FORMAT_LATC1_UNORM:
index be5818794c65b01775544c8e2b885b390bde8b46..d175d6caa65dd384d5fbe315661b879425d84786 100644 (file)
@@ -274,6 +274,7 @@ uint32_t r300_translate_texformat(enum pipe_format format,
             case PIPE_FORMAT_RGTC1_SNORM:
             case PIPE_FORMAT_LATC1_SNORM:
                 result |= sign_bit[0];
+                /* fallthrough */
             case PIPE_FORMAT_LATC1_UNORM:
             case PIPE_FORMAT_RGTC1_UNORM:
                 return R500_TX_FORMAT_ATI1N | result;
@@ -281,6 +282,7 @@ uint32_t r300_translate_texformat(enum pipe_format format,
             case PIPE_FORMAT_RGTC2_SNORM:
             case PIPE_FORMAT_LATC2_SNORM:
                 result |= sign_bit[1] | sign_bit[0];
+                /* fallthrough */
             case PIPE_FORMAT_RGTC2_UNORM:
             case PIPE_FORMAT_LATC2_UNORM:
                 return R400_TX_FORMAT_ATI2N | result;