package/pkg-generic.mk: fix show-build-order stdout pollution
authorSerj Kalichev <serj.kalichev@gmail.com>
Thu, 15 Nov 2018 15:45:42 +0000 (18:45 +0300)
committerThomas Petazzoni <thomas.petazzoni@bootlin.com>
Mon, 19 Nov 2018 21:25:30 +0000 (22:25 +0100)
The commands like "make show-build-order" or "make
<package>-show-build-order" show the build order and then print
"make[1]: Nothing to be done for 'show-build-order'" to stdout. It
pollutes output. Technically this message is true but it's not true
for user because he gets an information.

The <package>-show-build-order targets use $(info) for package name
printing.  The make utility doesn't consider the internal directive as
a command so it think that it's "Nothing to be done". The patch adds
the empty command to <package>-show-build-order to inform make utility
that taget makes some real actions.

Signed-off-by: Serj Kalichev <serj.kalichev@gmail.com>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
[Thomas: invert $(info) and @:, as suggested by Yann.]
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
package/pkg-generic.mk

index f34f46afc8c015f86673f88296464be14ef5b51d..7a95ea19cc62b31d2fbb1824a026cc9e3a26bc8c 100644 (file)
@@ -818,6 +818,7 @@ $(1)-show-recursive-rdepends:
                        $$(TOPDIR)/support/scripts/graph-depends -p $(1) --reverse -f -q
 
 $(1)-show-build-order: $$(patsubst %,%-show-build-order,$$($(2)_FINAL_ALL_DEPENDENCIES))
+       @:
        $$(info $(1))
 
 $(1)-graph-depends: graph-depends-requirements