Arm: Remove alternative from neon_softfp_fp16 directive.

There's a bit of a disconnect between the feature flags that don't test the fpu
and ones that do when the test itself also forces an architecture.  The forcing
of the architecture would change the defaults and without explicitly giving the
correct fpu again the test would fail.

I don't see a good way to solve this problem, really the feature tests should
ideally contain the extra options the test adds too, but for this specific case
it can be solved by always testing the fpu explicitly.

Committed under the GCC obvious

gcc/testsuite/ChangeLog:

	* lib/target-supports.exp
	(check_effective_target_arm_neon_softfp_fp16_ok_nocache): Drop non-fpu
	checking alternative.

From-SVN: r268943

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 86383671f069e9b6274278132194042e9712c987..e279a8e54ea3b24b3db5c91ab0e007c75cc0854a 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,9 @@
+2019-02-15  Tamar Christina  <tamar.christina@arm.com>
+
+       * lib/target-supports.exp
+       (check_effective_target_arm_neon_softfp_fp16_ok_nocache): Drop non-fpu
+       checking alternative.
+
 2019-02-15  Eric Botcazou  <ebotcazou@adacore.com>
 
        * gcc.target/sparc/struct-ret-check-1.c: Add -fno-pie option.

diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp
index a56796393a56d44921e82bcdd530d1d13a92ac42..94cb319bc123d17a3493da88cb15d9fb2c6cf194 100644 (file)
--- a/gcc/testsuite/lib/target-supports.exp
+++ b/gcc/testsuite/lib/target-supports.exp
@@ -3797,7 +3797,6 @@ proc check_effective_target_arm_neon_softfp_fp16_ok_nocache { } {
     if { [check_effective_target_arm32]
         && [check_effective_target_arm_neon_ok] } {
        foreach flags {"-mfpu=neon-fp16 -mfloat-abi=softfp"
-                      "-mfloat-abi=softfp -mfp16-format=ieee"
                       "-mfpu=neon-fp16 -mfloat-abi=softfp -mfp16-format=ieee"} {
            if { [check_no_compiler_messages_nocache arm_neon_softfp_fp16_ok object {
                #include "arm_neon.h"