re PR tree-optimization/87059 (internal compiler error: in set_value_range, at tree...

	PR tree-optimization/87059
	* builtins.c (expand_builtin_strncmp): Convert MIN_EXPR operand
	to the same type as the other.
	* fold-const.c (fold_binary_loc): Assert expectation.

From-SVN: r263855

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 1816d48528c0f81dcc15286914e9c7ea7f663de9..b183818918e8d75ba793b8c7866707ea4fb3e657 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,10 @@
+2018-08-25  Martin Sebor  <msebor@redhat.com>
+
+       PR tree-optimization/87059
+       * builtins.c (expand_builtin_strncmp): Convert MIN_EXPR operand
+       to the same type as the other.
+       * fold-const.c (fold_binary_loc): Assert expectation.
+
 2018-08-25  Iain Sandoe  <iain@sandoe.co.uk>
 
        * config/darwin.c (machopic_legitimize_pic_address): Clean up

diff --git a/gcc/builtins.c b/gcc/builtins.c
index b1a79f3f33f021e1f1f7f832c9ed2beca79c7e08..6a992bd939b87dcc5f576fc06a4a3d26df035319 100644 (file)
--- a/gcc/builtins.c
+++ b/gcc/builtins.c
@@ -4759,7 +4759,10 @@ expand_builtin_strncmp (tree exp, ATTRIBUTE_UNUSED rtx target,
   /* If we are not using the given length, we must incorporate it here.
      The actual new length parameter will be MIN(len,arg3) in this case.  */
   if (len != len3)
-    len = fold_build2_loc (loc, MIN_EXPR, TREE_TYPE (len), len, len3);
+    {
+      len = fold_convert_loc (loc, sizetype, len);
+      len = fold_build2_loc (loc, MIN_EXPR, TREE_TYPE (len), len, len3);
+    }
   rtx arg1_rtx = get_memory_rtx (arg1, len);
   rtx arg2_rtx = get_memory_rtx (arg2, len);
   rtx arg3_rtx = expand_normal (len);

diff --git a/gcc/fold-const.c b/gcc/fold-const.c
index b318fc7705fe50e50d415c89598810203b6c45a6..1e44a2454adbc26fefef595da5f07deed6521959 100644 (file)
--- a/gcc/fold-const.c
+++ b/gcc/fold-const.c
@@ -9326,6 +9326,14 @@ fold_binary_loc (location_t loc, enum tree_code code, tree type,
 
   if (kind == tcc_comparison || code == MIN_EXPR || code == MAX_EXPR)
     {
+      if (code == MIN_EXPR || code == MAX_EXPR)
+       {
+         tree typ0 = TREE_TYPE (arg0);
+         tree typ1 = TREE_TYPE (arg1);
+         gcc_assert (TYPE_SIGN (typ0) == TYPE_SIGN (typ1)
+                     && TYPE_MODE (typ0) == TYPE_MODE (typ1));
+       }
+
       STRIP_SIGN_NOPS (arg0);
       STRIP_SIGN_NOPS (arg1);
     }