mem-ruby: Fix debug prints for regular Stores
authorPouya Fotouhi <pfotouhi@ucdavis.edu>
Wed, 12 Aug 2020 06:31:29 +0000 (23:31 -0700)
committerPouya Fotouhi <pfotouhi@ucdavis.edu>
Thu, 13 Aug 2020 19:48:30 +0000 (19:48 +0000)
In the updated implementation of LL/SC (27103) the default value
of success was changed, which results in printing "SC_Failed" for
any regular stores.

Change-Id: I4f2e0b26233ce0cbdf948aadd19c9d81bf18bec0
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/32514
Reviewed-by: Jason Lowe-Power <power.jg@gmail.com>
Reviewed-by: Giacomo Travaglini <giacomo.travaglini@arm.com>
Maintainer: Jason Lowe-Power <power.jg@gmail.com>
Tested-by: kokoro <noreply+kokoro@google.com>
src/mem/ruby/system/Sequencer.cc

index aa134f4faa6d88b153554ee99d9278797227c2d1..42398e23e86bfe430412e253714ff15f29fd8717 100644 (file)
@@ -368,7 +368,7 @@ Sequencer::writeCallback(Addr address, DataBlock& data,
             (seq_req.m_type != RubyRequestType_Load_Linked) &&
             (seq_req.m_type != RubyRequestType_IFETCH)) {
             // LL/SC support (tested with ARMv8)
-            bool success = false;
+            bool success = true;
 
             if (seq_req.m_type != RubyRequestType_Store_Conditional) {
                 // Regular stores to addresses being monitored