expr.c (emit_move_insn_1): Abort if MODE argument is invalid.

1999-04-27 08:32 -0400  Zack Weinberg  <zack@rabi.columbia.edu>
	* expr.c (emit_move_insn_1): Abort if MODE argument is invalid.
	(compare): Punt if TREE_OPERAND (exp, 0) is an ERROR_MARK.

From-SVN: r26673

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index e58840416a79884bf626417f6ba364bc18cc4f0d..90bbe68247d3d0d3b315a5557e9d8cc868e6629f 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,8 @@
+1999-04-27 08:32 -0400  Zack Weinberg  <zack@rabi.columbia.edu>
+
+       * expr.c (emit_move_insn_1): Abort if MODE argument is invalid. 
+       (compare): Punt if TREE_OPERAND (exp, 0) is an ERROR_MARK.
+
 Tue Apr 27 01:33:43 1999  Jeffrey A Law  (law@cygnus.com)
 
        * Makefile.in (ORDINARY_FLAGS_TO_PASS): Renmaed from FLAGS_TO_PASS.

diff --git a/gcc/expr.c b/gcc/expr.c
index d2426df6822580dc8a66e7fa15a9d9a6afb23324..f8ca4267b7763000cc8888f5123dc1fa6fc6335c 100644 (file)
--- a/gcc/expr.c
+++ b/gcc/expr.c
@@ -2565,6 +2565,9 @@ emit_move_insn_1 (x, y)
   enum mode_class class = GET_MODE_CLASS (mode);
   int i;
 
+  if (mode >= MAX_MACHINE_MODE)
+      abort ();
+
   if (mov_optab->handlers[(int) mode].insn_code != CODE_FOR_nothing)
     return
       emit_insn (GEN_FCN (mov_optab->handlers[(int) mode].insn_code) (x, y));
@@ -11205,14 +11208,22 @@ compare (exp, signed_code, unsigned_code)
      register tree exp;
      enum rtx_code signed_code, unsigned_code;
 {
-  register rtx op0
-    = expand_expr (TREE_OPERAND (exp, 0), NULL_RTX, VOIDmode, 0);
-  register rtx op1
-    = expand_expr (TREE_OPERAND (exp, 1), NULL_RTX, VOIDmode, 0);
-  register tree type = TREE_TYPE (TREE_OPERAND (exp, 0));
-  register enum machine_mode mode = TYPE_MODE (type);
-  int unsignedp = TREE_UNSIGNED (type);
-  enum rtx_code code = unsignedp ? unsigned_code : signed_code;
+  register rtx op0, op1;
+  register tree type;
+  register enum machine_mode mode;
+  int unsignedp;
+  enum rtx_code code;
+
+  /* Don't crash if the comparison was erroneous.  */
+  op0 = expand_expr (TREE_OPERAND (exp, 0), NULL_RTX, VOIDmode, 0);
+  if (TREE_CODE (TREE_OPERAND (exp, 0)) == ERROR_MARK)
+    return op0;
+  
+  op1 = expand_expr (TREE_OPERAND (exp, 1), NULL_RTX, VOIDmode, 0);
+  type = TREE_TYPE (TREE_OPERAND (exp, 0));
+  mode = TYPE_MODE (type);
+  unsignedp = TREE_UNSIGNED (type);
+  code = unsignedp ? unsigned_code : signed_code;
 
 #ifdef HAVE_canonicalize_funcptr_for_compare
   /* If function pointers need to be "canonicalized" before they can