Initialize base_value in pascal_object_print_value

The val_print removal series introduced a new possibly-uninitialized
warning in p-valprint.c.  Examination of the code shows that the
warning does not indicate a real bug, so this patch silences the
warning by setting the variable in the catch clause of a try/catch.
(The obvious initialization did not work due to a "goto" in this
function.)

gdb/ChangeLog
2020-03-16  Tom Tromey  <tom@tromey.com>

	* p-valprint.c (pascal_object_print_value): Initialize
	base_value.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 7c506578738a2fc3b47721b53fe948adacabc6e5..cfd8c5b9d245ccd11513f6f6ee1644af8421f851 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2020-03-16  Tom Tromey  <tom@tromey.com>
+
+       * p-valprint.c (pascal_object_print_value): Initialize
+       base_value.
+
 2020-03-16  Anton Kolesov  <anton.kolesov@synopsys.com>
            Shahab Vahedi  <shahab@synopsys.com>
 

diff --git a/gdb/p-valprint.c b/gdb/p-valprint.c
index 35a4e59d250137f189a82e682acf8b729b2fd6a2..cbd7fb75e242c237aefc4919fa71751417d39d3d 100644 (file)
--- a/gdb/p-valprint.c
+++ b/gdb/p-valprint.c
@@ -739,6 +739,7 @@ pascal_object_print_value (struct value *val, struct ui_file *stream,
        }
       catch (const gdb_exception_error &ex)
        {
+         base_value = nullptr;
          if (ex.error == NOT_AVAILABLE_ERROR)
            skip = -1;
          else