mesa: Make link_program() take a gl_shader_program, not a GLuint.
authorKenneth Graunke <kenneth@whitecape.org>
Wed, 16 Mar 2016 00:08:17 +0000 (17:08 -0700)
committerKenneth Graunke <kenneth@whitecape.org>
Thu, 17 Mar 2016 06:57:11 +0000 (23:57 -0700)
In half the callers, we already have a pointer, and don't need
to look it up again.  This will also help with upcoming meta work.

Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Timothy Arceri <timothy.arceri@collabora.com>
src/mesa/main/shaderapi.c

index 43c4188cf2f75d030d05154001e39515ac609ff7..c7b1047bea10e4dae1c88f78e5f1f35ec5759493 100644 (file)
@@ -1021,11 +1021,8 @@ compile_shader(struct gl_context *ctx, struct gl_shader *sh)
  * Link a program's shaders.
  */
 static void
-link_program(struct gl_context *ctx, GLuint program)
+link_program(struct gl_context *ctx, struct gl_shader_program *shProg)
 {
-   struct gl_shader_program *shProg;
-
-   shProg = _mesa_lookup_shader_program_err(ctx, program, "glLinkProgram");
    if (!shProg)
       return;
 
@@ -1515,7 +1512,8 @@ _mesa_LinkProgram(GLuint programObj)
    GET_CURRENT_CONTEXT(ctx);
    if (MESA_VERBOSE & VERBOSE_API)
       _mesa_debug(ctx, "glLinkProgram %u\n", programObj);
-   link_program(ctx, programObj);
+   link_program(ctx, _mesa_lookup_shader_program_err(ctx, programObj,
+                                                     "glLinkProgram"));
 }
 
 #if defined(HAVE_SHA1)
@@ -2169,7 +2167,7 @@ _mesa_CreateShaderProgramv(GLenum type, GLsizei count,
         get_shaderiv(ctx, shader, GL_COMPILE_STATUS, &compiled);
         if (compiled) {
            attach_shader(ctx, program, shader);
-           link_program(ctx, program);
+           link_program(ctx, shProg);
            detach_shader(ctx, program, shader);
 
 #if 0