panfrost: Abort on unsupported blit
authorAlyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Thu, 9 Jul 2020 20:22:38 +0000 (16:22 -0400)
committerMarge Bot <eric+marge@anholt.net>
Thu, 16 Jul 2020 19:59:43 +0000 (19:59 +0000)
Instead of silently failing.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5858>

src/gallium/drivers/panfrost/pan_blit.c

index 420f85cca486c5ab74cb648a1a3a81b42ccb7d5e..c9fc8c83918ba44d7f53bae709ad4f6aaaa00cd4 100644 (file)
@@ -66,17 +66,9 @@ panfrost_u_blitter_blit(struct pipe_context *pipe,
                         const struct pipe_blit_info *info)
 {
         struct panfrost_context *ctx = pan_context(pipe);
-        struct panfrost_device *dev = pan_device(pipe->screen);
 
-        if (!util_blitter_is_blit_supported(ctx->blitter, info)) {
-                if (dev->debug & PAN_DBG_MSGS) {
-                        fprintf(stderr, "blit unsupported %s -> %s\n",
-                                        util_format_short_name(info->src.resource->format),
-                                        util_format_short_name(info->dst.resource->format));
-                }
-
-                return false;
-        }
+        if (!util_blitter_is_blit_supported(ctx->blitter, info))
+                unreachable("Unsupported blit\n");
 
         /* TODO: Scissor */