st/nine: Change comment relating to vertex shader inputs not matching declaration
authorAxel Davy <axel.davy@ens.fr>
Mon, 5 Jan 2015 15:26:27 +0000 (16:26 +0100)
committerEmil Velikov <emil.l.velikov@gmail.com>
Thu, 22 Jan 2015 22:16:24 +0000 (22:16 +0000)
Reviewed-by: Tiziano Bacocco <tizbac2@gmail.com>
Signed-off-by: Axel Davy <axel.davy@ens.fr>
src/gallium/state_trackers/nine/nine_state.c

index 1187a20bdb37e45830f2495289a9c6d7a0c50ff5..dad665133acc99c39865c4d0bdb78a74a1a06fb3 100644 (file)
@@ -214,11 +214,12 @@ update_vertex_elements(struct NineDevice9 *device)
             if (state->stream_freq[b] & D3DSTREAMSOURCE_INSTANCEDATA)
                 ve[n].instance_divisor = state->stream_freq[b] & 0x7FFFFF;
         } else {
-            /* TODO:
-             * If drivers don't want to handle this, insert a dummy buffer.
-             * But on which stream ?
-             */
-            /* no data, disable */
+            /* TODO: msdn doesn't specify what should happen when the vertex
+             * declaration doesn't match the vertex shader inputs.
+             * Some websites say the code will pass but nothing will get rendered.
+             * We should check and implement the correct behaviour. */
+            /* Put PIPE_FORMAT_NONE.
+             * Some drivers (r300) are very unhappy with that */
             ve[n].src_format = PIPE_FORMAT_NONE;
             ve[n].src_offset = 0;
             ve[n].instance_divisor = 0;