i915: remove early_z dri option
authorTimothy Arceri <tarceri@itsqueeze.com>
Wed, 15 Aug 2018 03:16:58 +0000 (13:16 +1000)
committerTimothy Arceri <tarceri@itsqueeze.com>
Mon, 20 Aug 2018 23:19:01 +0000 (09:19 +1000)
This driver is in maintenance mode so lets remove this hidden
unsafe option.

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
src/mesa/drivers/dri/i915/i915_vtbl.c
src/mesa/drivers/dri/i915/intel_context.c
src/mesa/drivers/dri/i915/intel_context.h
src/mesa/drivers/dri/i915/intel_screen.c

index 6a0a121856d7943a9f3309b774ebd753a5b03102..562c83a665f21afd820e704ff14eb5cff041486f 100644 (file)
@@ -609,14 +609,6 @@ i915_set_draw_region(struct intel_context *intel,
       value |= DV_PF_8888;
    }
 
-   /* This isn't quite safe, thus being hidden behind an option.  When changing
-    * the value of this bit, the pipeline needs to be MI_FLUSHed.  And it
-    * can only be set when a depth buffer is already defined.
-    */
-   if (intel->is_945 && intel->use_early_z &&
-       depth_region->tiling != I915_TILING_NONE)
-      value |= CLASSIC_EARLY_DEPTH;
-
    if (depth_region && depth_region->cpp == 4) {
       value |= DEPTH_FRMT_24_FIXED_8_OTHER;
    }
index 9a6e49dd82790d1fae94c19c03985e699d358c17..728d6d586998dd26f1e59c42a5aa7583c6c23f3d 100644 (file)
@@ -532,8 +532,6 @@ intelInitContext(struct intel_context *intel,
 
    intel_fbo_init(intel);
 
-   intel->use_early_z = driQueryOptionb(&intel->optionCache, "early_z");
-
    intel->prim.primitive = ~0;
 
    /* Force all software fallbacks */
index a8339896f65f270904b4e7a05b3976edf67737b7..580af53f9568c8c6b20b09530b1245f0eaee1c00 100644 (file)
@@ -238,8 +238,6 @@ struct intel_context
     */
    bool front_buffer_dirty;
 
-   bool use_early_z;
-
    __DRIcontext *driContext;
    struct intel_screen *intelScreen;
 
index 27be9219e477f6949b3f39d74dad3c07fa3cfeb0..3d4f7ae94aa7bc69bb6cbe97979e38dafbced964 100644 (file)
@@ -57,10 +57,6 @@ DRI_CONF_BEGIN
         DRI_CONF_DESC_END
       DRI_CONF_OPT_END
 
-      DRI_CONF_OPT_BEGIN_B(early_z, "false")
-        DRI_CONF_DESC(en, "Enable early Z in classic mode (unstable, 945-only).")
-      DRI_CONF_OPT_END
-
       DRI_CONF_OPT_BEGIN_B(fragment_shader, "true")
         DRI_CONF_DESC(en, "Enable limited ARB_fragment_shader support on 915/945.")
       DRI_CONF_OPT_END