asan: _bfd_elf_slurp_version_tables memory leak

Extends commit 6136093c0d00 to handle verdefs as well as verrefs.

	PR 30886
	* elf.c (_bfd_elf_slurp_version_tables): See free_contents for
	verdefs too.  Use free_contents rather than elf_tdata fields.

diff --git a/bfd/elf.c b/bfd/elf.c
index b5b0c69e09742592d772b93f2dd59becfdee37de..bd2a5e43551a3da7a341d04ce555efccee21a36a 100644 (file)
--- a/bfd/elf.c
+++ b/bfd/elf.c
@@ -9571,7 +9571,7 @@ _bfd_elf_slurp_version_tables (bfd *abfd, bool default_imported_symver)
        }
       elf_tdata (abfd)->cverrefs = i;
 
-      if (elf_tdata (abfd)->dt_verneed == NULL)
+      if (free_contents)
        free (contents);
       contents = NULL;
     }
@@ -9618,6 +9618,7 @@ _bfd_elf_slurp_version_tables (bfd *abfd, bool default_imported_symver)
          if (contents == NULL)
            goto error_return_verdef;
 
+         free_contents = true;
          BFD_ASSERT (sizeof (Elf_External_Verdef)
                      >= sizeof (Elf_External_Verdaux));
 
@@ -9767,7 +9768,7 @@ _bfd_elf_slurp_version_tables (bfd *abfd, bool default_imported_symver)
                     ((bfd_byte *) everdef + iverdef->vd_next));
        }
 
-      if (elf_tdata (abfd)->dt_verdef == NULL)
+      if (free_contents)
        free (contents);
       contents = NULL;
     }