[nvptx, libgcc] Fix Wbuiltin-declaration-mismatch in atomic.c
authorTom de Vries <tdevries@suse.de>
Wed, 9 Sep 2020 16:43:13 +0000 (18:43 +0200)
committerTom de Vries <tdevries@suse.de>
Wed, 9 Sep 2020 17:22:07 +0000 (19:22 +0200)
When building for target nvptx, we get this and similar warnings for libgcc:
...
src/libgcc/config/nvptx/atomic.c:39:1: warning: conflicting types for \
  built-in function ‘__sync_val_compare_and_swap_1’; expected \
  ‘unsigned char(volatile void *, unsigned char,  unsigned char)’ \
  [-Wbuiltin-declaration-mismatch]
...

Fix this by making sure in atomic.c that the pointers used are of type
'volatile void *'.

Tested by rebuilding atomic.c.

libgcc/ChangeLog:

* config/nvptx/atomic.c (__SYNC_SUBWORD_COMPARE_AND_SWAP): Fix
Wbuiltin-declaration-mismatch.

libgcc/config/nvptx/atomic.c

index e1ea078692afe0b4286cf3092691c49541b83ba2..60f21f3ff7fc59fb61768593cc86cd638fdd8ba1 100644 (file)
 #define __SYNC_SUBWORD_COMPARE_AND_SWAP(TYPE, SIZE)                         \
                                                                             \
 TYPE                                                                        \
-__sync_val_compare_and_swap_##SIZE (TYPE *ptr, TYPE oldval, TYPE newval)     \
+__sync_val_compare_and_swap_##SIZE (volatile void *vptr, TYPE oldval,       \
+                                   TYPE newval)                             \
 {                                                                           \
-  unsigned int *wordptr = (unsigned int *)((__UINTPTR_TYPE__ ) ptr & ~3UL);  \
-  int shift = ((__UINTPTR_TYPE__ ) ptr & 3UL) * 8;                          \
+  volatile TYPE *ptr = vptr;                                                \
+  volatile unsigned int *wordptr                                            \
+    = (volatile unsigned int *)((__UINTPTR_TYPE__) ptr & ~3UL);             \
+  int shift = ((__UINTPTR_TYPE__) ptr & 3UL) * 8;                           \
   unsigned int valmask = (1 << (SIZE * 8)) - 1;                                     \
   unsigned int wordmask = ~(valmask << shift);                              \
   unsigned int oldword = *wordptr;                                          \
@@ -64,7 +67,8 @@ __sync_val_compare_and_swap_##SIZE (TYPE *ptr, TYPE oldval, TYPE newval)     \
 }                                                                           \
                                                                             \
 bool                                                                        \
-__sync_bool_compare_and_swap_##SIZE (TYPE *ptr, TYPE oldval, TYPE newval)    \
+__sync_bool_compare_and_swap_##SIZE (volatile void *ptr, TYPE oldval,       \
+                                    TYPE newval)                            \
 {                                                                           \
   return __sync_val_compare_and_swap_##SIZE (ptr, oldval, newval) == oldval; \
 }