zink: do not use SpvDimRect
authorErik Faye-Lund <erik.faye-lund@collabora.com>
Tue, 4 Feb 2020 11:20:36 +0000 (12:20 +0100)
committerMarge Bot <eric+marge@anholt.net>
Fri, 14 Feb 2020 10:51:46 +0000 (10:51 +0000)
Vulkan doesn't support SpvDimRect. But we don't need to pass this at
all, as we already mark the sampler as un-normalized.

Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3764>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3764>

src/gallium/drivers/zink/nir_to_spirv/nir_to_spirv.c
src/gallium/drivers/zink/zink_context.c

index fa2c7b0bf94d509c401481255ea4fda0c2e2f4f9..9e516eae56d70a499abc362fc7eade0e12f81a1e 100644 (file)
@@ -369,7 +369,7 @@ type_to_dim(enum glsl_sampler_dim gdim, bool *is_ms)
    case GLSL_SAMPLER_DIM_CUBE:
       return SpvDimCube;
    case GLSL_SAMPLER_DIM_RECT:
-      return SpvDimRect;
+      return SpvDim2D;
    case GLSL_SAMPLER_DIM_BUF:
       return SpvDimBuffer;
    case GLSL_SAMPLER_DIM_EXTERNAL:
index d6d3f33b115e844acda7cf2d0e924b5d807f49f5..c5fb0e2e0b0d5f5816ce8b31958c678a8b2c64e3 100644 (file)
@@ -203,7 +203,7 @@ image_view_type(enum pipe_texture_target target)
    case PIPE_TEXTURE_CUBE: return VK_IMAGE_VIEW_TYPE_CUBE;
    case PIPE_TEXTURE_CUBE_ARRAY: return VK_IMAGE_VIEW_TYPE_CUBE_ARRAY;
    case PIPE_TEXTURE_3D: return VK_IMAGE_VIEW_TYPE_3D;
-   case PIPE_TEXTURE_RECT: return VK_IMAGE_VIEW_TYPE_2D; /* not sure */
+   case PIPE_TEXTURE_RECT: return VK_IMAGE_VIEW_TYPE_2D;
    default:
       unreachable("unexpected target");
    }