libctf: get rid of a disruptive public include of <sys/param.h>

This hoary old header defines things like MAX that users of libctf might
perfectly reasonably define themselves.

The CTF headers do not need it: move it into libctf/ctf-impl.h instead.

include/
	* ctf-api.h (includes): No longer include <sys/param.h>.
libctf/
	* ctf-impl.h (includes): Include <sys/param.h> here.

diff --git a/include/ChangeLog b/include/ChangeLog
index ce7c17377a09bc9a204a8f13771fed45b0084524..b53956f3486451fde16d2d81931ad16bf9ce46f7 100644 (file)
--- a/include/ChangeLog
+++ b/include/ChangeLog
@@ -1,3 +1,7 @@
+2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
+
+       * ctf-api.h (includes): No longer include <sys/param.h>.
+
 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 
        * ctf-api.h (ctf_link_add_cu_mapping): New.

diff --git a/include/ctf-api.h b/include/ctf-api.h
index 4ac5fea8bc697420674d6cffca6d7d92a5d8fcf7..f50bb0a01992353d80f5b3b269f3b1c82f7288df 100644 (file)
--- a/include/ctf-api.h
+++ b/include/ctf-api.h
@@ -24,7 +24,6 @@
 #ifndef        _CTF_API_H
 #define        _CTF_API_H
 
-#include <sys/param.h>
 #include <sys/types.h>
 #include <ctf.h>
 #include <zlib.h>

diff --git a/libctf/ChangeLog b/libctf/ChangeLog
index 83b316701b2aff171999d17140a666ffecdef523..9637cf37af9daa1197232b3df28ca66cac7188ee 100644 (file)
--- a/libctf/ChangeLog
+++ b/libctf/ChangeLog
@@ -1,3 +1,7 @@
+2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
+
+       * ctf-impl.h (includes): Include <sys/param.h> here.
+
 2019-07-30  Nick Alcock  <nick.alcock@oracle.com>
 
        * ctf-open.c (flip_lbls): Eschew for-loop initial declarations.

diff --git a/libctf/ctf-impl.h b/libctf/ctf-impl.h
index 554b1872cbf48342a0b7e3a5947d7214c4a4f9ec..211099e1e87c19e9027b90089895a76efd4f5641 100644 (file)
--- a/libctf/ctf-impl.h
+++ b/libctf/ctf-impl.h
@@ -22,6 +22,7 @@
 
 #include "config.h"
 #include <errno.h>
+#include <sys/param.h>
 #include "ctf-decls.h"
 #include <ctf-api.h>
 #include <sys/types.h>