[Ada] Faulty ignored Ghost code removal

This patch ensures that removal of ignored Ghost code is the absolute last
operation performed on the tree. Previously the removal was performed prior to
issuing delayed warnings, however the warning mechanism may see a heavily
modified tree and fail.

No small reproducer available.

2018-07-17  Hristian Kirtchev  <kirtchev@adacore.com>

gcc/ada/

	* frontend.adb (Frontend): The removal of ignored Ghost code must be
	the last semantic operation performed on the tree.

From-SVN: r262795

diff --git a/gcc/ada/ChangeLog b/gcc/ada/ChangeLog
index 9fe7a3b69d7c69c49a3cf97bf283a8b50d846642..1b8da215beaf2c5b23e3f24d57ad42f2ab3c94b8 100644 (file)
--- a/gcc/ada/ChangeLog
+++ b/gcc/ada/ChangeLog
@@ -1,3 +1,8 @@
+2018-07-17  Hristian Kirtchev  <kirtchev@adacore.com>
+
+       * frontend.adb (Frontend): The removal of ignored Ghost code must be
+       the last semantic operation performed on the tree.
+
 2018-07-17  Hristian Kirtchev  <kirtchev@adacore.com>
 
        * frontend.adb (Frontend): Update the call to Register_Config_Switches.

diff --git a/gcc/ada/frontend.adb b/gcc/ada/frontend.adb
index 1af5587110fdb5d1474d64c77566907d08999968..1da6f9aa502ead44ffddb04323ecec281b0890fd 100644 (file)
--- a/gcc/ada/frontend.adb
+++ b/gcc/ada/frontend.adb
@@ -451,11 +451,6 @@ begin
 
                Check_Elaboration_Scenarios;
 
-               --  Remove any ignored Ghost code as it must not appear in the
-               --  executable.
-
-               Remove_Ignored_Ghost_Code;
-
             --  Examine all top level scenarios collected during analysis and
             --  resolution in order to diagnose conditional ABEs, even in the
             --  presence of serious errors.
@@ -483,6 +478,14 @@ begin
             Sem_Warn.Output_Unreferenced_Messages;
             Sem_Warn.Check_Unused_Withs;
             Sem_Warn.Output_Unused_Warnings_Off_Warnings;
+
+            --  Remove any ignored Ghost code as it must not appear in the
+            --  executable. This action must be performed last because it
+            --  heavily alters the tree.
+
+            if Operating_Mode = Generate_Code or else GNATprove_Mode then
+               Remove_Ignored_Ghost_Code;
+            end if;
          end if;
       end if;
    end;