Return std::string from gdb_bfd_errmsg

This changes gdb_bfd_errmsg to return a std::string, removing a
cleanup.  This approach may be slightly less efficient than the
previous code, but I don't believe this is very important in this
situation.

gdb/ChangeLog
2018-09-13  Tom Tromey  <tom@tromey.com>

	* utils.h (gdb_bfd_errmsg): Return std::string.
	* exec.c (exec_file_attach): Update.
	* compile/compile-object-load.c (compile_object_load): Update.
	* utils.c (gdb_bfd_errmsg): Return std::string.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 7351e5d742d1ab5e690c04dd275d7943ea0f2373..d087871f58c30da171b3180779bff4f006c1f538 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+2018-09-13  Tom Tromey  <tom@tromey.com>
+
+       * utils.h (gdb_bfd_errmsg): Return std::string.
+       * exec.c (exec_file_attach): Update.
+       * compile/compile-object-load.c (compile_object_load): Update.
+       * utils.c (gdb_bfd_errmsg): Return std::string.
+
 2018-09-13  Tom Tromey  <tom@tromey.com>
 
        * procfs.c (struct procinfo_deleter): New.

diff --git a/gdb/compile/compile-object-load.c b/gdb/compile/compile-object-load.c
index 873750b94405d527878fa4d5b1c2da10176a73db..40053d281a1a6a4b1e3fda422fd1e9babdb39fce 100644 (file)
--- a/gdb/compile/compile-object-load.c
+++ b/gdb/compile/compile-object-load.c
@@ -638,7 +638,8 @@ compile_object_load (const compile_file_names &file_names,
 
   if (!bfd_check_format_matches (abfd.get (), bfd_object, &matching))
     error (_("\"%s\": not in loadable format: %s"),
-          filename.get (), gdb_bfd_errmsg (bfd_get_error (), matching));
+          filename.get (),
+          gdb_bfd_errmsg (bfd_get_error (), matching).c_str ());
 
   if ((bfd_get_file_flags (abfd.get ()) & (EXEC_P | DYNAMIC)) != 0)
     error (_("\"%s\": not in object format."), filename.get ());

diff --git a/gdb/exec.c b/gdb/exec.c
index 3023ff7e5aa9570a4f8200137c70c4dd263ef4ed..6e44b0e821bec95d6b64425e2dfd953dfe15bba3 100644 (file)
--- a/gdb/exec.c
+++ b/gdb/exec.c
@@ -362,7 +362,7 @@ exec_file_attach (const char *filename, int from_tty)
          exec_close ();
          error (_("\"%s\": not in executable format: %s"),
                 scratch_pathname,
-                gdb_bfd_errmsg (bfd_get_error (), matching));
+                gdb_bfd_errmsg (bfd_get_error (), matching).c_str ());
        }
 
       if (build_section_table (exec_bfd, &sections, &sections_end))

diff --git a/gdb/utils.c b/gdb/utils.c
index 7a8c80c64edbe3a2936c8c605b5d18bd391452c8..d7980fe3a186465bdf07c82adbf2d50829b6866b 100644 (file)
--- a/gdb/utils.c
+++ b/gdb/utils.c
@@ -2921,39 +2921,26 @@ compare_positive_ints (const void *ap, const void *bp)
 #define AMBIGUOUS_MESS2        \
   ".\nUse \"set gnutarget format-name\" to specify the format."
 
-const char *
+std::string
 gdb_bfd_errmsg (bfd_error_type error_tag, char **matching)
 {
-  char *ret, *retp;
-  int ret_len;
   char **p;
 
   /* Check if errmsg just need simple return.  */
   if (error_tag != bfd_error_file_ambiguously_recognized || matching == NULL)
     return bfd_errmsg (error_tag);
 
-  ret_len = strlen (bfd_errmsg (error_tag)) + strlen (AMBIGUOUS_MESS1)
-            + strlen (AMBIGUOUS_MESS2);
-  for (p = matching; *p; p++)
-    ret_len += strlen (*p) + 1;
-  ret = (char *) xmalloc (ret_len + 1);
-  retp = ret;
-  make_cleanup (xfree, ret);
-
-  strcpy (retp, bfd_errmsg (error_tag));
-  retp += strlen (retp);
-
-  strcpy (retp, AMBIGUOUS_MESS1);
-  retp += strlen (retp);
+  std::string ret (bfd_errmsg (error_tag));
+  ret += AMBIGUOUS_MESS1;
 
   for (p = matching; *p; p++)
     {
-      sprintf (retp, " %s", *p);
-      retp += strlen (retp);
+      ret += " ";
+      ret += *p;
     }
-  xfree (matching);
+  ret += AMBIGUOUS_MESS2;
 
-  strcpy (retp, AMBIGUOUS_MESS2);
+  xfree (matching);
 
   return ret;
 }

diff --git a/gdb/utils.h b/gdb/utils.h
index 68523994b947a6f058887bdc43ff4533932a7508..fa9a59087dacfbc56fb4040c5cc6fc6c7af0b3a3 100644 (file)
--- a/gdb/utils.h
+++ b/gdb/utils.h
@@ -115,7 +115,7 @@ compare_cstrings (const char *str1, const char *str2)
    MATCHING, if non-NULL, is the corresponding argument to
    bfd_check_format_matches, and will be freed.  */
 
-extern const char *gdb_bfd_errmsg (bfd_error_type error_tag, char **matching);
+extern std::string gdb_bfd_errmsg (bfd_error_type error_tag, char **matching);
 
 /* Reset the prompt_for_continue clock.  */
 void reset_prompt_for_continue_wait_time (void);