Fix couple of function args that expect to be passed CONST pointers, and

boolean functions that were returning NULL, which can be "void *" rather
than just bare 0.

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 455a6b42fcf91bd91571d27898b864cc8fe081c7..4f22991ac6fcc17bbd48789c30059f774edea068 100644 (file)
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,11 @@
+Tue Apr 14 14:34:42 1992  Fred Fish  (fnf@cygnus.com)
+
+       * elf.c (bfd_add_strtab, bfd_add_2_to_strtab):  CONST spreads
+       like ooze.
+       * elf.c (elf_compute_section_file_positions,
+       elf_write_object_contents):  Return boolean, not NULL (which
+       can be void *).
+
 Fri Apr 10 22:29:18 1992  Fred Fish  (fnf@cygnus.com)
 
        * configure.in:  Recognize ncr3000 config

diff --git a/bfd/elf.c b/bfd/elf.c
index 26b962da46d9f2da50f06479f26671c422e4b783..9841b00167199e4fe95a6eedd726ebd8ca5f6346 100644 (file)
--- a/bfd/elf.c
+++ b/bfd/elf.c
@@ -518,7 +518,7 @@ static int
 DEFUN(bfd_add_to_strtab, (abfd, ss, str),
       bfd              *abfd AND
       struct strtab    *ss AND
-      char             *str)
+      CONST char       *str)
 {
   /* should search first, but for now: */
   /* include the trailing NUL */
@@ -540,7 +540,7 @@ DEFUN(bfd_add_2_to_strtab, (abfd, ss, str, str2),
       bfd              *abfd AND
       struct strtab    *ss AND
       char             *str AND
-      char             *str2)
+      CONST char       *str2)
 {
   /* should search first, but for now: */
   /* include the trailing NUL */
@@ -1598,7 +1598,7 @@ DEFUN (elf_compute_section_file_positions, (abfd), bfd *abfd)
   if (! i_shdrp)
     {
       bfd_error = no_memory;
-      return (NULL);
+      return (false);
     }
   for (count=0; count < maxsections; count++) 
     {
@@ -1631,6 +1631,7 @@ DEFUN (elf_compute_section_file_positions, (abfd), bfd *abfd)
 
   bfd_map_over_sections(abfd, elf_fake_sections, &est);
   elf_onesymtab (abfd) = est.symtab_section;
+  return (true);
 }
 
 static boolean
@@ -1764,7 +1765,7 @@ DEFUN (elf_write_object_contents, (abfd), bfd *abfd)
   if (! x_shdrp)
     {
       bfd_error = no_memory;
-      return (NULL);
+      return (false);
     }
 
   fprintf(stderr, "ELF>> total sections: %d\n", i_ehdrp->e_shnum);