OBVIOUS Remove a useless const char *type and its initialization.

Valgrind detected a leak for the line:
  type = xstrdup ("auto");

as the compile probably dropped the type variable completely, as its
only usage was this initialization.

So, remove the useless variable.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 95591f6485a85b25676e0b150b9b8643e19098dd..87db7f5fb27b1e23929224483c541bbc5f847100 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2018-11-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
+
+       * language.c (type): Remove.
+       (_initialize_language): Remove assignment to type.
+
 2018-11-02  Joel Brobecker  <brobecker@adacore.com>
 
        * aarch64-ravenscar-thread.h, aarch64-ravenscar-thread.c: New files.

diff --git a/gdb/language.c b/gdb/language.c
index 21eda576b0cb309a8703cb89ba30a1b25ea73edf..e2f400161b37484a0df31be5d3e13b8aef18989e 100644 (file)
--- a/gdb/language.c
+++ b/gdb/language.c
@@ -105,10 +105,9 @@ static const struct language_defn *languages[] = {
   &ada_language_defn,
 };
 
-/* The current values of the "set language/type/range" enum
+/* The current values of the "set language/range/case-sensitive" enum
    commands.  */
 static const char *language;
-static const char *type;
 static const char *range;
 static const char *case_sensitive;
 
@@ -1174,7 +1173,6 @@ For Fortran the default is off; for other languages the default is on."),
   add_set_language_command ();
 
   language = xstrdup ("auto");
-  type = xstrdup ("auto");
   range = xstrdup ("auto");
   case_sensitive = xstrdup ("auto");