gdb/amd-dbgapi-target: Use inf param in detach
authorLancelot SIX <lancelot.six@amd.com>
Fri, 10 Mar 2023 15:34:26 +0000 (15:34 +0000)
committerLancelot SIX <lancelot.six@amd.com>
Wed, 19 Jul 2023 08:47:20 +0000 (09:47 +0100)
Current implementation of amd_dbgapi_target::detach (inferior *, int)
does the following:

  remove_breakpoints_inf (current_inferior ());
  detach_amd_dbgapi (inf);
  beneath ()->detach (inf, from_tty);

I find that using a mix of `current_inferior ()` and `inf` disturbing.
At this point, we know that both are the same (target_detach does assert
that `inf == current_inferior ()` before calling target_ops::detach).

To improve consistency, this patch replaces `current_inferior ()` with
`inf` in amd_dbgapi_target::detach.

Change-Id: I01b7ba2e661c25839438354b509d7abbddb7c5ed
Approved-By: Pedro Alves <pedro@palves.net>
gdb/amd-dbgapi-target.c

index 5565cf907fa8f3acf1859d4c85b6bccc95835246..40f24b5fc2f18ef1ee05fc71c863a5108d694909 100644 (file)
@@ -1463,7 +1463,7 @@ amd_dbgapi_target::detach (inferior *inf, int from_tty)
      Breakpoints may still be inserted because the inferior may be running in
      non-stop mode, or because GDB changed the default setting to leave all
      breakpoints inserted in all-stop mode when all threads are stopped.  */
-  remove_breakpoints_inf (current_inferior ());
+  remove_breakpoints_inf (inf);
 
   detach_amd_dbgapi (inf);
   beneath ()->detach (inf, from_tty);