configure: error out when building GLX w/o the X11 platform
authorEmil Velikov <emil.velikov@collabora.com>
Wed, 3 May 2017 14:57:31 +0000 (15:57 +0100)
committerEmil Velikov <emil.l.velikov@gmail.com>
Fri, 19 May 2017 18:44:12 +0000 (19:44 +0100)
Building EGL/Vulkan/other without X11, while GLX is enabled is confusing
and misleading. In practise anyone aiming at the former will also
disable GLX.

The inverse (some examples below) should still work:
 ./configure --disable-glx --with-platforms=x11 --with-vulkan-drivers=intel
 ./configure --disable-glx --with-platforms=x11 --enable-egl

Keep in mind that the X11 platform is enabled, by default.

Cc: <mesa-stable@lists.freedesktop.org>
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
Reviewed-by: Eric Engestrom <eric@engestrom.ch>
configure.ac

index 56521127b4c11cc0d69a83edd47ceda0bfd91239..e6dcea7329359ab3f3d0da439a75080af9a8d15a 100644 (file)
@@ -1719,6 +1719,12 @@ for plat in $platforms; do
        esac
 done
 
+if test "x$enable_glx" != xno; then
+    if ! echo "$platforms" | grep -q 'x11'; then
+        AC_MSG_ERROR([Building without the x11 platform as GLX is enabled, is not supported])
+    fi
+fi
+
 AM_CONDITIONAL(HAVE_PLATFORM_X11, echo "$platforms" | grep -q 'x11')
 AM_CONDITIONAL(HAVE_PLATFORM_WAYLAND, echo "$platforms" | grep -q 'wayland')
 AM_CONDITIONAL(HAVE_PLATFORM_DRM, echo "$platforms" | grep -q 'drm')