This patch fixes the current comment in gdb_remote_download, which is
false (the "except if that's already where it is" part). It also
improves it, by explaining why pass TOFILE through standard_output_file,
even it is an absolute path.
gdb/testsuite/ChangeLog:
* lib/gdb.exp (gdb_remote_download): Fix and extend comment.
+2016-04-13 Simon Marchi <simon.marchi@ericsson.com>
+
+ * lib/gdb.exp (gdb_remote_download): Fix and extend comment.
+
2016-04-13 Simon Marchi <simon.marchi@ericsson.com>
* boards/gdbserver-base.exp (${board}_download): Copy source file to
return $destname
} else {
- # When the DEST is local, we copy the file to the test directory
- # (where the executable is), except if that's already where it is.
+ # When the DEST is local, we copy the file to the test directory (where
+ # the executable is).
+ #
+ # Note that we pass TOFILE through standard_output_file, regardless of
+ # whether it is absolute or relative, because we don't want the tests
+ # to be able to write outside their standard output directory.
+
set tofile [standard_output_file $tofile]
file copy -force $fromfile $tofile