objcopy: Close some memory leaks in error paths

Closes some memory leaks within objcopy for error paths.

binutils/ChangeLog:

	* objcopy.c (copy_section): Add extra calls to free for error
	paths.

diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index f1e1f9bd3f20931d35ccb4027c716b17322ae639..09f76b92212fe90d004d190754e836e60a799348 100644 (file)
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,3 +1,8 @@
+2016-11-04  Andrew Burgess  <andrew.burgess@embecosm.com>
+
+       * objcopy.c (copy_section): Add extra calls to free for error
+       paths.
+
 2016-11-04  Tom Tromey  <tom@tromey.com>
 
        * dwarf-mode.el (dwarf-browse): Set default-directory.  Bump

diff --git a/binutils/objcopy.c b/binutils/objcopy.c
index 1821c0ce1be5c1cd39106b9b9fe67fa22c8a6c21..d40cfcb2bb605486d5f6134d3804471acc8a0bc8 100644 (file)
--- a/binutils/objcopy.c
+++ b/binutils/objcopy.c
@@ -3375,6 +3375,7 @@ copy_section (bfd *ibfd, sec_ptr isection, void *obfdarg)
        {
          status = 1;
          bfd_nonfatal_message (NULL, ibfd, isection, NULL);
+         free (memhunk);
          return;
        }
 
@@ -3428,6 +3429,7 @@ copy_section (bfd *ibfd, sec_ptr isection, void *obfdarg)
        {
          status = 1;
          bfd_nonfatal_message (NULL, obfd, osection, NULL);
+         free (memhunk);
          return;
        }
       free (memhunk);
@@ -3449,6 +3451,7 @@ copy_section (bfd *ibfd, sec_ptr isection, void *obfdarg)
        {
          status = 1;
          bfd_nonfatal_message (NULL, obfd, osection, NULL);
+         free (memhunk);
          return;
        }
       free (memhunk);