support/download: fix the bzr helper
authorYann E. MORIN <yann.morin.1998@free.fr>
Mon, 7 Jul 2014 21:44:32 +0000 (23:44 +0200)
committerPeter Korsgaard <peter@korsgaard.com>
Tue, 8 Jul 2014 08:53:39 +0000 (10:53 +0200)
bzr uses the name of the extension of the output file to known what
output format to use: tar, tgz, tar.bz2... If no extension is
recognised, bzr will output to a directory.

Since we use 'mktemp .XXXXXX' to generate temporary files, it obviously
never ends with a recognised extension. Thus, bzr expects the output to
be a directory, and fails since it is a file.

Fix that by forcing the output format.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
support/download/bzr

index 3f52ee9eb741075a7c9ad01ac9a318a742b939f5..19d837d305a6145f3003dddeb0f6d32b2eed4c58 100755 (executable)
@@ -26,7 +26,7 @@ tmp_output="$( mktemp "${output}.XXXXXX" )"
 # - finally, we atomically rename to the final file
 
 ret=1
-if ${BZR} export "${tmp_dl}" "${repo}" -r "${rev}"; then
+if ${BZR} export --format=tgz "${tmp_dl}" "${repo}" -r "${rev}"; then
     if mv "${tmp_dl}" "${tmp_output}"; then
         mv "${tmp_output}" "${output}"
         ret=0