LRA: side_effects_p stmts' output is not invariant (PR89721)

PR89721 shows LRA treating an unspec_volatile's result as invariant,
which of course isn't correct.  This patch fixes it.

	PR rtl-optimization/89721
	* lra-constraints (invariant_p): Return false if side_effects_p holds.

From-SVN: r269716

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 55d80e563678e75e88bd7971c4eb35c5d92d15ab..67dc0bfdbb6999d7948ab22ecb9812a31415a2ba 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,8 @@
+2019-03-15  Segher Boessenkool  <segher@kernel.crashing.org>
+
+       PR rtl-optimization/89721
+       * lra-constraints (invariant_p): Return false if side_effects_p holds.
+
 2019-03-15  Kelvin Nilsen  <kelvin@gcc.gnu.org>
 
        PR target/87532

diff --git a/gcc/lra-constraints.c b/gcc/lra-constraints.c
index d7d69c6ba50c4f738e0196e3adafeb094e649543..ccca1303ec2a6e24f49e29f77dfd7e541651a6e0 100644 (file)
--- a/gcc/lra-constraints.c
+++ b/gcc/lra-constraints.c
@@ -5839,6 +5839,9 @@ invariant_p (const_rtx x)
   enum rtx_code code;
   int i, j;
 
+  if (side_effects_p (x))
+    return false;
+
   code = GET_CODE (x);
   mode = GET_MODE (x);
   if (code == SUBREG)