re PR rtl-optimization/80385 (Segfault in commutative_operand_precedence() rtlanal...

	PR rtl-optimization/80385
	* simplify-rtx.c (simplify_unary_operation_1): Don't transform
	(not (neg X)) into (plus X -1) for complex or non-integral modes.

	* g++.dg/opt/pr80385.C: New test.

From-SVN: r246850

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 900e58ce58e48090e82eff2536b76ac8cbf961af..ea434f6e280ae2f78363ae45244829fbb8ea1e50 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,5 +1,9 @@
 2017-04-11  Jakub Jelinek  <jakub@redhat.com>
 
+       PR rtl-optimization/80385
+       * simplify-rtx.c (simplify_unary_operation_1): Don't transform
+       (not (neg X)) into (plus X -1) for complex or non-integral modes.
+
        PR libgomp/80394
        * omp-low.c (scan_omp_task): Don't optimize away empty tasks
        if they have any depend clauses.

diff --git a/gcc/simplify-rtx.c b/gcc/simplify-rtx.c
index cff7e4d3e3f15a9ecda18e8396c82d5b8b76710e..4bbbe2354e3f21f2bfa98987d97ad64b4a27032b 100644 (file)
--- a/gcc/simplify-rtx.c
+++ b/gcc/simplify-rtx.c
@@ -932,8 +932,10 @@ simplify_unary_operation_1 (enum rtx_code code, machine_mode mode, rtx op)
          && XEXP (op, 1) == constm1_rtx)
        return simplify_gen_unary (NEG, mode, XEXP (op, 0), mode);
 
-      /* Similarly, (not (neg X)) is (plus X -1).  */
-      if (GET_CODE (op) == NEG)
+      /* Similarly, (not (neg X)) is (plus X -1).  Only do this for
+        modes that have CONSTM1_RTX, i.e. MODE_INT, MODE_PARTIAL_INT
+        and MODE_VECTOR_INT.  */
+      if (GET_CODE (op) == NEG && CONSTM1_RTX (mode))
        return simplify_gen_binary (PLUS, mode, XEXP (op, 0),
                                    CONSTM1_RTX (mode));
 

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 584813f361b5363842cb1f393aa6638fccc7128d..a01828881749eb66caed763734dbcdc1cdccaf44 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2017-04-11  Jakub Jelinek  <jakub@redhat.com>
+
+       PR rtl-optimization/80385
+       * g++.dg/opt/pr80385.C: New test.
+
 2017-04-11  Martin Liska  <mliska@suse.cz>
 
        PR ipa/80212

diff --git a/gcc/testsuite/g++.dg/opt/pr80385.C b/gcc/testsuite/g++.dg/opt/pr80385.C
new file mode 100644 (file)
index 0000000..f18abc9
--- /dev/null
+++ b/gcc/testsuite/g++.dg/opt/pr80385.C
@@ -0,0 +1,14 @@
+// PR rtl-optimization/80385
+// { dg-do compile { target { i?86-*-* x86_64-*-* } } }
+// { dg-options "-Ofast -msse2" }
+
+#include <x86intrin.h>
+
+__m128 a, e;
+struct A { __m128 b; A (); A (__m128 x) : b(x) {} };
+A operator+ (A, A);
+A operator- (A) { __m128 c = -a; return c; }
+A foo (A x) { __m128 d = x.b; return _mm_andnot_ps (d, e); }
+struct B { A n[1]; };
+void bar (B x) { A f = foo (x.n[0]); A g = f + A (); }
+void baz () { B h; B i; A j; i.n[0] = -j; h = i; B k = h; bar (k); }