mem: Delete the MessageReq and MessageResp memory commands.
authorGabe Black <gabeblack@google.com>
Wed, 11 Sep 2019 20:54:42 +0000 (13:54 -0700)
committerGabe Black <gabeblack@google.com>
Fri, 18 Oct 2019 01:43:55 +0000 (01:43 +0000)
Now that Message*Port is gone, there are no users of these two memory
commands. They can now be deleted, simplifying the memory system
slightly.

Change-Id: If157dade4a3fb2610756c2ee81dc0c3fac670a26
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/20824
Reviewed-by: Gabe Black <gabeblack@google.com>
Reviewed-by: Jason Lowe-Power <jason@lowepower.com>
Maintainer: Gabe Black <gabeblack@google.com>
Tested-by: kokoro <noreply+kokoro@google.com>
src/mem/packet.cc
src/mem/packet.hh

index 1d1b5b8d797bf4b36cdbffefae5f6d0529234731..551ccd8be69f9f74e7a49b503ce4c5a48215fbb6 100644 (file)
@@ -180,11 +180,8 @@ MemCmd::commandInfo[] =
     /* SwapResp -- for Swap ldstub type operations */
     { SET4(IsRead, IsWrite, IsResponse, HasData),
             InvalidCmd, "SwapResp" },
-    /* IntReq -- for interrupts */
-    { SET4(IsWrite, IsRequest, NeedsResponse, HasData),
-        MessageResp, "MessageReq" },
-    /* IntResp -- for interrupts */
-    { SET2(IsWrite, IsResponse), InvalidCmd, "MessageResp" },
+    { 0, InvalidCmd, "Deprecated_MessageReq" },
+    { 0, InvalidCmd, "Deprecated_MessageResp" },
     /* MemFenceReq -- for synchronization requests */
     {SET2(IsRequest, NeedsResponse), MemFenceResp, "MemFenceReq"},
     /* MemFenceResp -- for synchronization responses */
index 130cc41adc5df6ee23de8bfdbae8d22ed2a32312..407172f9893fd65ad4697b9beda1990a9d4e942e 100644 (file)
@@ -115,9 +115,8 @@ class MemCmd
         StoreCondResp,
         SwapReq,
         SwapResp,
-        MessageReq,
-        MessageResp,
-        MemFenceReq,
+        // MessageReq and MessageResp are deprecated.
+        MemFenceReq = SwapResp + 3,
         MemFenceResp,
         CleanSharedReq,
         CleanSharedResp,