Use gdb::unique_xmalloc_ptr in auto_load_section_scripts

This changes auto_load_section_scripts to use gdb::unique_xmalloc_ptr,
allowing the removal of a cleanup.

2018-02-09  Tom Tromey  <tom@tromey.com>

	* auto-load.c (auto_load_section_scripts): Use
	gdb::unique_xmalloc_ptr.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index adc3d19d3b2ae4a93e87802db7315eaea5c25e83..9e03aa29080b97e6610497dfa785d36b66887fc5 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2018-02-09  Tom Tromey  <tom@tromey.com>
+
+       * auto-load.c (auto_load_section_scripts): Use
+       gdb::unique_xmalloc_ptr.
+
 2018-02-09  Tom Tromey  <tom@tromey.com>
 
        * auto-load.c (execute_script_contents): Use std::string.

diff --git a/gdb/auto-load.c b/gdb/auto-load.c
index 1f3d366a56373e87472cf69fb45be06d8666b20f..b79341faf6f0a554128a6ea1abfae415695b3d80 100644 (file)
--- a/gdb/auto-load.c
+++ b/gdb/auto-load.c
@@ -1153,13 +1153,11 @@ auto_load_section_scripts (struct objfile *objfile, const char *section_name)
             section_name, bfd_get_filename (abfd));
   else
     {
-      struct cleanup *cleanups;
-      char *p = (char *) data;
+      gdb::unique_xmalloc_ptr<bfd_byte> data_holder (data);
 
-      cleanups = make_cleanup (xfree, p);
+      char *p = (char *) data;
       source_section_scripts (objfile, section_name, p,
                              p + bfd_get_section_size (scripts_sect));
-      do_cleanups (cleanups);
     }
 }