ruby: avoid using g_system_ptr for event scheduling

This patch removes the use of g_system_ptr for event scheduling. Each consumer
object now needs to specify upfront an EventManager object it would use for
scheduling events. This makes the ruby memory system more amenable for a
multi-threaded simulation.

diff --git a/src/mem/ruby/common/Consumer.cc b/src/mem/ruby/common/Consumer.cc
index 1f7aeebd58f8141a3bd9642f7f7d954727a78813..de6a8f448d9691414851426e7016494b50add7aa 100644 (file)
--- a/src/mem/ruby/common/Consumer.cc
+++ b/src/mem/ruby/common/Consumer.cc
@@ -33,23 +33,11 @@
 void
 Consumer::scheduleEvent(Time timeDelta)
 {
-    scheduleEvent(g_system_ptr, timeDelta);
-}
-
-void
-Consumer::scheduleEvent(EventManager *em, Time timeDelta)
-{
-    scheduleEventAbsolute(em, timeDelta + g_system_ptr->getTime());
+    scheduleEventAbsolute(timeDelta + g_system_ptr->getTime());
 }
 
 void
 Consumer::scheduleEventAbsolute(Time timeAbs)
-{
-    scheduleEventAbsolute(g_system_ptr, timeAbs);
-}
-
-void
-Consumer::scheduleEventAbsolute(EventManager *em, Time timeAbs)
 {
     Tick evt_time = g_system_ptr->clockPeriod() * timeAbs;
     if (!alreadyScheduled(evt_time)) {

diff --git a/src/mem/ruby/common/Consumer.hh b/src/mem/ruby/common/Consumer.hh
index 6a67bde39694c94b83af52d5d22fa93b12f0b9bf..a10abf3622f8feff2bb9c12dc894ac4c87dcdf68 100644 (file)
--- a/src/mem/ruby/common/Consumer.hh
+++ b/src/mem/ruby/common/Consumer.hh
@@ -44,8 +44,8 @@
 class Consumer
 {
   public:
-    Consumer()
-        : m_last_scheduled_wakeup(0), m_last_wakeup(0)
+    Consumer(EventManager *_em)
+        : m_last_scheduled_wakeup(0), m_last_wakeup(0), em(_em)
     {
     }
 
@@ -88,8 +88,6 @@ class Consumer
         m_scheduled_wakeups.erase(time);
     }
 
-    void scheduleEvent(EventManager* em, Time timeDelta);
-    void scheduleEventAbsolute(EventManager* em, Time timeAbs);
     void scheduleEvent(Time timeDelta);
     void scheduleEventAbsolute(Time timeAbs);
 
@@ -97,6 +95,7 @@ class Consumer
     Tick m_last_scheduled_wakeup;
     std::set<Tick> m_scheduled_wakeups;
     Tick m_last_wakeup;
+    EventManager *em;
 
     class ConsumerEvent : public Event
     {

diff --git a/src/mem/ruby/network/garnet/fixed-pipeline/InputUnit_d.cc b/src/mem/ruby/network/garnet/fixed-pipeline/InputUnit_d.cc
index adafa4d24039e4908b30712bea57bd6e5d039de7..62b8cd574ee4701768beca3b3f0e80f94e5dee68 100644 (file)
--- a/src/mem/ruby/network/garnet/fixed-pipeline/InputUnit_d.cc
+++ b/src/mem/ruby/network/garnet/fixed-pipeline/InputUnit_d.cc
@@ -35,7 +35,7 @@
 using namespace std;
 using m5::stl_helpers::deletePointers;
 
-InputUnit_d::InputUnit_d(int id, Router_d *router)
+InputUnit_d::InputUnit_d(int id, Router_d *router) : Consumer(router)
 {
     m_id = id;
     m_router = router;

diff --git a/src/mem/ruby/network/garnet/fixed-pipeline/NetworkInterface_d.cc b/src/mem/ruby/network/garnet/fixed-pipeline/NetworkInterface_d.cc
index 4bdce2a34ca5f20c408192bb309a53698ffc3f4e..b0538d19f81d3855f52391c6b767f7ef8a33106f 100644 (file)
--- a/src/mem/ruby/network/garnet/fixed-pipeline/NetworkInterface_d.cc
+++ b/src/mem/ruby/network/garnet/fixed-pipeline/NetworkInterface_d.cc
@@ -44,6 +44,7 @@ using m5::stl_helpers::deletePointers;
 
 NetworkInterface_d::NetworkInterface_d(int id, int virtual_networks,
                                        GarnetNetwork_d *network_ptr)
+    : Consumer(network_ptr)
 {
     m_id = id;
     m_net_ptr = network_ptr;

diff --git a/src/mem/ruby/network/garnet/fixed-pipeline/NetworkLink_d.cc b/src/mem/ruby/network/garnet/fixed-pipeline/NetworkLink_d.cc
index ac41263e3b9afee8dcc097be36d6e47c41bd03cd..432097a916e4b0ffdcb54b1423b800da6ac7ed4d 100644 (file)
--- a/src/mem/ruby/network/garnet/fixed-pipeline/NetworkLink_d.cc
+++ b/src/mem/ruby/network/garnet/fixed-pipeline/NetworkLink_d.cc
@@ -32,7 +32,7 @@
 #include "mem/ruby/network/garnet/fixed-pipeline/NetworkLink_d.hh"
 
 NetworkLink_d::NetworkLink_d(const Params *p)
-    : SimObject(p)
+    : SimObject(p), Consumer(this)
 {
     m_latency = p->link_latency;
     channel_width = p->channel_width;

diff --git a/src/mem/ruby/network/garnet/fixed-pipeline/OutputUnit_d.cc b/src/mem/ruby/network/garnet/fixed-pipeline/OutputUnit_d.cc
index 429ff4d915eefaa5f2e6b4287df9a1d591ad64a6..33d1583e1ceae24f674b27cb52d636c973ca5e96 100644 (file)
--- a/src/mem/ruby/network/garnet/fixed-pipeline/OutputUnit_d.cc
+++ b/src/mem/ruby/network/garnet/fixed-pipeline/OutputUnit_d.cc
@@ -36,6 +36,7 @@ using namespace std;
 using m5::stl_helpers::deletePointers;
 
 OutputUnit_d::OutputUnit_d(int id, Router_d *router)
+    : Consumer(router)
 {
     m_id = id;
     m_router = router;

diff --git a/src/mem/ruby/network/garnet/fixed-pipeline/SWallocator_d.cc b/src/mem/ruby/network/garnet/fixed-pipeline/SWallocator_d.cc
index 530e8f1b261abd04972af8a11584d97fac166ec3..41ff8d48250ead845be25c0d11c26fea65a7422b 100644 (file)
--- a/src/mem/ruby/network/garnet/fixed-pipeline/SWallocator_d.cc
+++ b/src/mem/ruby/network/garnet/fixed-pipeline/SWallocator_d.cc
@@ -35,6 +35,7 @@
 #include "mem/ruby/network/garnet/fixed-pipeline/SWallocator_d.hh"
 
 SWallocator_d::SWallocator_d(Router_d *router)
+    : Consumer(router)
 {
     m_router = router;
     m_num_vcs = m_router->get_num_vcs();

diff --git a/src/mem/ruby/network/garnet/fixed-pipeline/Switch_d.cc b/src/mem/ruby/network/garnet/fixed-pipeline/Switch_d.cc
index 12c00d9d09444bb11b22914075985482551236d9..1cb31c3e38bb5ad19ee2bab6659456ba8eef335b 100644 (file)
--- a/src/mem/ruby/network/garnet/fixed-pipeline/Switch_d.cc
+++ b/src/mem/ruby/network/garnet/fixed-pipeline/Switch_d.cc
@@ -37,6 +37,7 @@
 using m5::stl_helpers::deletePointers;
 
 Switch_d::Switch_d(Router_d *router)
+    : Consumer(router)
 {
     m_router = router;
     m_num_vcs = m_router->get_num_vcs();

diff --git a/src/mem/ruby/network/garnet/fixed-pipeline/VCallocator_d.cc b/src/mem/ruby/network/garnet/fixed-pipeline/VCallocator_d.cc
index 3940e1d6a03886968a62d9ad2604c50909db8d04..75533fb1001deb632b26f55fa2f2e80489d77d7e 100644 (file)
--- a/src/mem/ruby/network/garnet/fixed-pipeline/VCallocator_d.cc
+++ b/src/mem/ruby/network/garnet/fixed-pipeline/VCallocator_d.cc
@@ -35,6 +35,7 @@
 #include "mem/ruby/network/garnet/fixed-pipeline/VCallocator_d.hh"
 
 VCallocator_d::VCallocator_d(Router_d *router)
+    : Consumer(router)
 {
     m_router = router;
     m_num_vcs = m_router->get_num_vcs();

diff --git a/src/mem/ruby/network/garnet/flexible-pipeline/FlexibleConsumer.hh b/src/mem/ruby/network/garnet/flexible-pipeline/FlexibleConsumer.hh
index 04a4ac95aa5e3c858487a3a0f0be79f1ceee22a6..a2d6db60b9041b3152f08127adec2f9013ba1ab5 100644 (file)
--- a/src/mem/ruby/network/garnet/flexible-pipeline/FlexibleConsumer.hh
+++ b/src/mem/ruby/network/garnet/flexible-pipeline/FlexibleConsumer.hh
@@ -38,6 +38,7 @@
 class FlexibleConsumer : public Consumer
 {
   public:
+    FlexibleConsumer(EventManager *em) : Consumer(em) {}
     virtual bool isBufferNotFull(int vc, int inport) { return true; }
     virtual void grant_vc(int out_port, int vc, Time grant_time) {}
     virtual void release_vc(int out_port, int vc, Time release_time) {}

diff --git a/src/mem/ruby/network/garnet/flexible-pipeline/NetworkInterface.cc b/src/mem/ruby/network/garnet/flexible-pipeline/NetworkInterface.cc
index cc7dd71466a5913cf5325ff60245b8239e5ee00f..824acce80f33ab2b4832be35571124df585671fa 100644 (file)
--- a/src/mem/ruby/network/garnet/flexible-pipeline/NetworkInterface.cc
+++ b/src/mem/ruby/network/garnet/flexible-pipeline/NetworkInterface.cc
@@ -44,6 +44,7 @@ using m5::stl_helpers::deletePointers;
 
 NetworkInterface::NetworkInterface(int id, int virtual_networks,
                                    GarnetNetwork *network_ptr)
+    : FlexibleConsumer(network_ptr)
 {
     m_id = id;
     m_net_ptr = network_ptr;

diff --git a/src/mem/ruby/network/garnet/flexible-pipeline/NetworkLink.cc b/src/mem/ruby/network/garnet/flexible-pipeline/NetworkLink.cc
index fb7c9bd447ea967dc342817d3837117c32b6ac4b..3908d34c311014801d636273d78ed76ab3fd70bf 100644 (file)
--- a/src/mem/ruby/network/garnet/flexible-pipeline/NetworkLink.cc
+++ b/src/mem/ruby/network/garnet/flexible-pipeline/NetworkLink.cc
@@ -32,7 +32,7 @@
 #include "mem/ruby/network/garnet/flexible-pipeline/NetworkLink.hh"
 
 NetworkLink::NetworkLink(const Params *p)
-    : SimObject(p)
+    : SimObject(p), FlexibleConsumer(this)
 {
     linkBuffer = new flitBuffer();
     m_in_port = 0;
@@ -140,7 +140,7 @@ NetworkLink::wakeup()
     flit *t_flit = link_srcQueue->getTopFlit();
     t_flit->set_time(g_system_ptr->getTime() + m_latency);
     linkBuffer->insert(t_flit);
-    link_consumer->scheduleEvent(this, m_latency);
+    link_consumer->scheduleEvent(m_latency);
     m_link_utilized++;
     m_vc_load[t_flit->get_vc()]++;
 }

diff --git a/src/mem/ruby/network/garnet/flexible-pipeline/Router.cc b/src/mem/ruby/network/garnet/flexible-pipeline/Router.cc
index 28e9fc4977276a9d6924c4bf24e0d8e581f10b32..88361d35a7e82244c2f570a1e0717618f3f481dc 100644 (file)
--- a/src/mem/ruby/network/garnet/flexible-pipeline/Router.cc
+++ b/src/mem/ruby/network/garnet/flexible-pipeline/Router.cc
@@ -41,7 +41,7 @@ using namespace std;
 using m5::stl_helpers::deletePointers;
 
 Router::Router(const Params *p)
-    : BasicRouter(p)
+    : BasicRouter(p), FlexibleConsumer(this)
 {
     m_id = p->router_id;
     m_virtual_networks = p->virt_nets;

diff --git a/src/mem/ruby/network/garnet/flexible-pipeline/VCarbiter.cc b/src/mem/ruby/network/garnet/flexible-pipeline/VCarbiter.cc
index e68e1b12f21c5281fcda5a801e3bcab2f1a9007a..5ed336699e1d9176f3cbc6c9dc5018bd42e1aced 100644 (file)
--- a/src/mem/ruby/network/garnet/flexible-pipeline/VCarbiter.cc
+++ b/src/mem/ruby/network/garnet/flexible-pipeline/VCarbiter.cc
@@ -32,6 +32,7 @@
 #include "mem/ruby/network/garnet/flexible-pipeline/VCarbiter.hh"
 
 VCarbiter::VCarbiter(Router *router)
+    : Consumer(router)
 {
     m_router = router;
 }

diff --git a/src/mem/ruby/network/simple/PerfectSwitch.cc b/src/mem/ruby/network/simple/PerfectSwitch.cc
index 66065e22c125f3f3c7ce3fa623e3299cdc9290dc..0ead3ac30b9af26e8faca5543139a0dd5a9b9e3c 100644 (file)
--- a/src/mem/ruby/network/simple/PerfectSwitch.cc
+++ b/src/mem/ruby/network/simple/PerfectSwitch.cc
@@ -49,6 +49,7 @@ operator<(const LinkOrder& l1, const LinkOrder& l2)
 }
 
 PerfectSwitch::PerfectSwitch(SwitchID sid, SimpleNetwork* network_ptr)
+    : Consumer(network_ptr)
 {
     m_virtual_networks = network_ptr->getNumberOfVirtualNetworks();
     m_switch_id = sid;

diff --git a/src/mem/ruby/network/simple/Switch.cc b/src/mem/ruby/network/simple/Switch.cc
index 922807a0b3fc96b984e9418f2cc8414f19ad6817..42a4efae3c84a8fb8ed0e58050df72aa5e7a6d89 100644 (file)
--- a/src/mem/ruby/network/simple/Switch.cc
+++ b/src/mem/ruby/network/simple/Switch.cc
@@ -74,7 +74,8 @@ Switch::addOutPort(const vector<MessageBuffer*>& out,
 
     // Create a throttle
     throttle_ptr = new Throttle(m_switch_id, m_throttles.size(), link_latency,
-                                bw_multiplier, net_ptr->getEndpointBandwidth());
+                                bw_multiplier, net_ptr->getEndpointBandwidth(),
+                                net_ptr);
     m_throttles.push_back(throttle_ptr);
 
     // Create one buffer per vnet (these are intermediaryQueues)
@@ -214,4 +215,3 @@ Switch::print(std::ostream& out) const
     // FIXME printing
     out << "[Switch]";
 }
-

diff --git a/src/mem/ruby/network/simple/Switch.hh b/src/mem/ruby/network/simple/Switch.hh
index 31ea6add12cf614afa76f2e4939bcbb1cad75a49..0bc1e5eca1ffadb3640a075209c3e174f5653f3f 100644 (file)
--- a/src/mem/ruby/network/simple/Switch.hh
+++ b/src/mem/ruby/network/simple/Switch.hh
@@ -42,8 +42,6 @@
 #include <iostream>
 #include <vector>
 
-#include "mem/ruby/common/Global.hh"
-
 class MessageBuffer;
 class PerfectSwitch;
 class NetDest;

diff --git a/src/mem/ruby/network/simple/Throttle.cc b/src/mem/ruby/network/simple/Throttle.cc
index 05dfc2553ec42eda5ac4e7b9b570c1c1c3a42704..e4dc715278db69521f9822974b08e7ffc2d7a5c9 100644 (file)
--- a/src/mem/ruby/network/simple/Throttle.cc
+++ b/src/mem/ruby/network/simple/Throttle.cc
@@ -49,14 +49,18 @@ const int PRIORITY_SWITCH_LIMIT = 128;
 static int network_message_to_size(NetworkMessage* net_msg_ptr);
 
 Throttle::Throttle(int sID, NodeID node, int link_latency,
-                   int link_bandwidth_multiplier, int endpoint_bandwidth)
+                   int link_bandwidth_multiplier, int endpoint_bandwidth,
+                   EventManager *em)
+    : Consumer(em)
 {
     init(node, link_latency, link_bandwidth_multiplier, endpoint_bandwidth);
     m_sID = sID;
 }
 
 Throttle::Throttle(NodeID node, int link_latency,
-                   int link_bandwidth_multiplier, int endpoint_bandwidth)
+                   int link_bandwidth_multiplier, int endpoint_bandwidth,
+                   EventManager *em)
+    : Consumer(em)
 {
     init(node, link_latency, link_bandwidth_multiplier, endpoint_bandwidth);
     m_sID = 0;

diff --git a/src/mem/ruby/network/simple/Throttle.hh b/src/mem/ruby/network/simple/Throttle.hh
index 37a53b80a99cba63442e6f64c97d99dbdb951c5b..b86a247d21165866a025d985d550385c42a4ba8f 100644 (file)
--- a/src/mem/ruby/network/simple/Throttle.hh
+++ b/src/mem/ruby/network/simple/Throttle.hh
@@ -53,9 +53,10 @@ class Throttle : public Consumer
 {
   public:
     Throttle(int sID, NodeID node, int link_latency,
-             int link_bandwidth_multiplier, int endpoint_bandwidth);
+             int link_bandwidth_multiplier, int endpoint_bandwidth,
+             EventManager *em);
     Throttle(NodeID node, int link_latency, int link_bandwidth_multiplier,
-             int endpoint_bandwidth);
+             int endpoint_bandwidth, EventManager *em);
     ~Throttle() {}
 
     std::string name()

diff --git a/src/mem/ruby/slicc_interface/AbstractController.cc b/src/mem/ruby/slicc_interface/AbstractController.cc
index 04bbb87d800b9f17191c747b3dbaf3061ec39c98..eca68ad05437663d0574caf815ddd371b2118aeb 100644 (file)
--- a/src/mem/ruby/slicc_interface/AbstractController.cc
+++ b/src/mem/ruby/slicc_interface/AbstractController.cc
@@ -29,7 +29,8 @@
 #include "mem/ruby/slicc_interface/AbstractController.hh"
 #include "mem/ruby/system/System.hh"
 
-AbstractController::AbstractController(const Params *p) : SimObject(p)
+AbstractController::AbstractController(const Params *p)
+    : SimObject(p), Consumer(this)
 {
   p->ruby_system->registerAbstractController(this);
 }

diff --git a/src/mem/ruby/system/AbstractMemOrCache.hh b/src/mem/ruby/system/AbstractMemOrCache.hh
index 4d1fee69a8a82aea8b882739c7e7b1de1f8ce1d6..3f3fb6fa0aab06d90e6ee03b368f7d916f2d6370 100644 (file)
--- a/src/mem/ruby/system/AbstractMemOrCache.hh
+++ b/src/mem/ruby/system/AbstractMemOrCache.hh
@@ -35,7 +35,6 @@
 
 class Consumer;
 class MemoryNode;
-class Message;
 
 class AbstractMemOrCache
 {

diff --git a/src/mem/ruby/system/MemoryControl.cc b/src/mem/ruby/system/MemoryControl.cc
index f1ebc07fa5ddbf4369c3b9abaeb3c32fa8de0f67..c5ddb0c44d7ebc4d61e7f096250659811cae2627 100644 (file)
--- a/src/mem/ruby/system/MemoryControl.cc
+++ b/src/mem/ruby/system/MemoryControl.cc
@@ -42,7 +42,8 @@
 #include "mem/ruby/system/System.hh"
 
 using namespace std;
-MemoryControl::MemoryControl(const Params *p) : ClockedObject(p), m_event(this)
+MemoryControl::MemoryControl(const Params *p)
+    : ClockedObject(p), Consumer(this), m_event(this)
 {
     g_system_ptr->registerMemController(this);
 }

diff --git a/src/mem/ruby/system/System.hh b/src/mem/ruby/system/System.hh
index c7d0050854de70edcfc4b0b6f7b4bf213d17507a..f7e0efc2a237d6dba6b01caa1020e6da5c15e7d1 100644 (file)
--- a/src/mem/ruby/system/System.hh
+++ b/src/mem/ruby/system/System.hh
@@ -133,7 +133,6 @@ class RubySystem : public ClockedObject
 
     void init();
 
-    static void printSystemConfig(std::ostream& out);
     void readCompressedTrace(std::string filename,
                              uint8_t *&raw_data,
                              uint64& uncompressed_trace_size);

diff --git a/src/mem/ruby/system/WireBuffer.cc b/src/mem/ruby/system/WireBuffer.cc
index fb12998beccbcbc4aacd8319875152c31c252bbd..0845b3c8df1aef994acd170a5cfe52abbcfa4303 100644 (file)
--- a/src/mem/ruby/system/WireBuffer.cc
+++ b/src/mem/ruby/system/WireBuffer.cc
@@ -38,9 +38,6 @@
 
 using namespace std;
 
-class Consumer;
-
-
 // Output operator definition
 
 ostream&

diff --git a/src/mem/ruby/system/WireBuffer.hh b/src/mem/ruby/system/WireBuffer.hh
index c22fab70b5ee27036081391d58b160edcc93b9b1..07da965c8d3a1f0a030a507c2e0e0615c3c362c5 100644 (file)
--- a/src/mem/ruby/system/WireBuffer.hh
+++ b/src/mem/ruby/system/WireBuffer.hh
@@ -37,7 +37,7 @@
 #include <vector>
 
 #include "mem/ruby/buffers/MessageBufferNode.hh"
-#include "mem/ruby/common/Global.hh"
+#include "mem/ruby/common/Consumer.hh"
 #include "params/RubyWireBuffer.hh"
 #include "sim/sim_object.hh"
 
@@ -51,7 +51,6 @@
 // separated by a network in real systems to simplify coherence.
 /////////////////////////////////////////////////////////////////////////////
 
-class Consumer;
 class Message; 
 
 class WireBuffer : public SimObject

diff --git a/src/mem/slicc/ast/FuncCallExprAST.py b/src/mem/slicc/ast/FuncCallExprAST.py
index ab6261de270a0d036b9753bf5d74797f5b1c0774..1438934e683723dc8824281d34eacc2c5edb3ef2 100644 (file)
--- a/src/mem/slicc/ast/FuncCallExprAST.py
+++ b/src/mem/slicc/ast/FuncCallExprAST.py
@@ -142,7 +142,7 @@ class FuncCallExprAST(ExprAST):
     }
 
     if (result == TransitionResult_ResourceStall) {
-        scheduleEvent(this, 1);
+        scheduleEvent(1);
 
         // Cannot do anything with this transition, go check next doable transition (mostly likely of next port)
     }
@@ -173,7 +173,7 @@ class FuncCallExprAST(ExprAST):
     }
 
     if (result1 == TransitionResult_ResourceStall) {
-        scheduleEvent(this, 1);
+        scheduleEvent(1);
         // Cannot do anything with this transition, go check next
         // doable transition (mostly likely of next port)
     }

diff --git a/src/mem/slicc/symbols/StateMachine.py b/src/mem/slicc/symbols/StateMachine.py
index 47f7daa00abbb47ccfd969d6de3f914270ca9d68..43153c773647ecbe37d17aac9b7835668a3c7296 100644 (file)
--- a/src/mem/slicc/symbols/StateMachine.py
+++ b/src/mem/slicc/symbols/StateMachine.py
@@ -1047,7 +1047,7 @@ ${ident}_Controller::wakeup()
             g_system_ptr->getProfiler()->controllerBusy(m_machineID);
 
             // Wakeup in another cycle and try again
-            scheduleEvent(this, 1);
+            scheduleEvent(1);
             break;
         }
 ''')