gallium/radeon: fixed division by zero
authorJakob Sinclair <sinclair.jakob@openmailbox.org>
Wed, 18 May 2016 17:48:29 +0000 (19:48 +0200)
committerMarek Olšák <marek.olsak@amd.com>
Tue, 31 May 2016 10:51:20 +0000 (12:51 +0200)
Coverity is getting a false positive that a division by zero can occur
here. This change will silence the Coverity warnings as a division by zero
cannot occur in this case.

Signed-off-by: Jakob Sinclair <sinclair.jakob@openmailbox.org>
Reviewed-by: Nicolai Hähnle <nicolai.haehnle@amd.com>
Signed-off-by: Marek Olšák <marek.olsak@amd.com>
src/gallium/drivers/radeon/r600_test_dma.c

index c203b4d9a2ef3be6611a14a16f0c9a2fa28a6f55..1e60f6affa74e1c12290833ab98e786125c589aa 100644 (file)
@@ -345,6 +345,9 @@ void r600_test_dma(struct r600_common_screen *rscreen)
                                        dstx = rand() % (tdst.width0 - width + 1) & ~0x7;
                                        dsty = rand() % (tdst.height0 - height + 1) & ~0x7;
                                } else {
+                                       /* just make sure that it doesn't divide by zero */
+                                       assert(max_width > 0 && max_height > 0);
+
                                        width = (rand() % max_width) + 1;
                                        height = (rand() % max_height) + 1;