hostapd: make ACS dependent on nl80211
authorAlexander Mukhin <alexander.i.mukhin@gmail.com>
Sat, 30 Dec 2017 15:57:35 +0000 (18:57 +0300)
committerThomas Petazzoni <thomas.petazzoni@bootlin.com>
Mon, 2 Apr 2018 16:30:52 +0000 (18:30 +0200)
According to hostapd's defconfig file, ACS is currently only supported
through the nl80211 driver. Search through the source code also confirms
that ACS machinery is present in the nl80211 driver only.

Although hostapd can be built with ACS enabled and nl80211 disabled, an
attempt to use ACS with other drivers by setting a wireless channel to 0
results in a runtime failure (driver doesn't accept this value). So we
might save a user from selecting a meaningless combination by making ACS
dependent on nl80211.

Signed-off-by: Alexander Mukhin <alexander.i.mukhin@gmail.com>
Reviewed-by: Sam Voss <sam.voss@rockwellcollins.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
package/hostapd/Config.in

index f6182a926894d50f026cf6a89a32d25bdf4d7b42..d23e5e1dca04d04d3c3bfd5831c785d1e5f7e019 100644 (file)
@@ -53,6 +53,7 @@ config BR2_PACKAGE_HOSTAPD_HAS_WIFI_DRIVERS
 config BR2_PACKAGE_HOSTAPD_ACS
        bool "Enable ACS"
        default y
+       depends on BR2_PACKAGE_HOSTAPD_DRIVER_NL80211
        help
          Enable support for standard ACS (Automatic Channel Selection).
          Some propietary drivers use a custom algorithm which requires
@@ -60,6 +61,9 @@ config BR2_PACKAGE_HOSTAPD_ACS
          causing hostapd to use the standard one which doesn't work
          for those cases.
 
+comment "ACS is currently only supported through the nl80211 driver"
+       depends on !BR2_PACKAGE_HOSTAPD_DRIVER_NL80211
+
 config BR2_PACKAGE_HOSTAPD_EAP
        bool "Enable EAP"
        depends on !BR2_STATIC_LIBS