r600g/radeonsi: Reduce or even drop special treatment of persistent mappings
authorMichel Dänzer <michel.daenzer@amd.com>
Tue, 22 Jul 2014 09:37:59 +0000 (18:37 +0900)
committerMichel Dänzer <michel@daenzer.net>
Fri, 1 Aug 2014 02:04:16 +0000 (11:04 +0900)
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
src/gallium/drivers/radeon/r600_buffer_common.c

index 4e6b8978efb89a6a3db3b730145ba9f092d30e54..154c33d73910700f748eb25c7791a8b995054655 100644 (file)
@@ -127,13 +127,17 @@ bool r600_init_resource(struct r600_common_screen *rscreen,
                break;
        }
 
-       /* Use GTT for all persistent mappings, because they are
-        * always cached and coherent. */
-       if (res->b.b.target == PIPE_BUFFER &&
+       /* Use GTT for all persistent mappings with older kernels, because they
+        * didn't always flush the HDP cache before CS execution.
+        *
+        * Write-combined CPU mappings are fine, the kernel ensures all CPU
+        * writes finish before the GPU executes a command stream.
+        */
+       if (rscreen->info.drm_minor < 40 &&
+           res->b.b.target == PIPE_BUFFER &&
            res->b.b.flags & (PIPE_RESOURCE_FLAG_MAP_PERSISTENT |
                              PIPE_RESOURCE_FLAG_MAP_COHERENT)) {
                res->domains = RADEON_DOMAIN_GTT;
-               flags = 0;
        }
 
        /* Tiled textures are unmappable. Always put them in VRAM. */