Use '--readnever' when invoking GDB from gcore.in

Back when I proposed the '--readnever' feature, I somehow forgot or
decided not to include the bits related to gcore.in in the original
patch.  This patch finally updates the gcore script to invoke GDB
using '--readnever'.

We've been carrying this patch on Fedora GDB for quite some time, and
as expected the corefiles generated by gcore on Fedora don't have
problems, which I think is the best indicator that the it's safe to
generate corefiles using '--readnever'.

gdb/ChangeLog:
2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>

	* gcore.in: Add '--readnever' option when invoking GDB.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 6a551dfa64acf3d15128311d375fbfb111cfc06b..9a5740210b39f177c00613f6061f5ff633a7b739 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
+
+       * gcore.in: Add '--readnever' option when invoking GDB.
+
 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 
        * MAINTAINERS: Update my email address.

diff --git a/gdb/gcore.in b/gdb/gcore.in
index 25602396d5798e292f7a67603d8ee1b93ae9fee8..b9770ea4153a9bb7b9a6a8a172fb0758d47952c0 100644 (file)
--- a/gdb/gcore.in
+++ b/gdb/gcore.in
@@ -97,7 +97,8 @@ for pid in "$@"
 do
        # `</dev/null' to avoid touching interactive terminal if it is
        # available but not accessible as GDB would get stopped on SIGTTIN.
-       "$binary_path/@GDB_TRANSFORM_NAME@" </dev/null --nx --batch \
+       "$binary_path/@GDB_TRANSFORM_NAME@" </dev/null \
+           --nx --batch --readnever \
            -ex "set pagination off" -ex "set height 0" -ex "set width 0" \
            "${dump_all_cmds[@]}" \
            -ex "attach $pid" -ex "gcore $prefix.$pid" -ex detach -ex quit