projects
/
binutils-gdb.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
ef632b4
)
gdb/linux-nat: don't memset siginfo on failure in linux_nat_get_siginfo
author
Simon Marchi
<simon.marchi@polymtl.ca>
Fri, 2 Dec 2022 20:09:22 +0000
(15:09 -0500)
committer
Simon Marchi
<simon.marchi@efficios.com>
Mon, 5 Dec 2022 21:38:45 +0000
(16:38 -0500)
No caller cares about the value of *SIGINFO on failure. It's also
documented in the function doc that *SIGINFO is uninitialized (I
understand "untouched") on failure.
Change-Id: I5ef38a5f58e3635e109b919ddf6f827f38f1225a
gdb/linux-nat.c
patch
|
blob
|
history
diff --git
a/gdb/linux-nat.c
b/gdb/linux-nat.c
index 7b6a1f98d66dbc4557d1ab5bd3e74077bea07ee3..c47b8db9299c3222befb1a1fa03cd8feac421480 100644
(file)
--- a/
gdb/linux-nat.c
+++ b/
gdb/linux-nat.c
@@
-4446,12
+4446,8
@@
linux_nat_get_siginfo (ptid_t ptid, siginfo_t *siginfo)
errno = 0;
ptrace (PTRACE_GETSIGINFO, pid, (PTRACE_TYPE_ARG3) 0, siginfo);
- if (errno != 0)
- {
- memset (siginfo, 0, sizeof (*siginfo));
- return false;
- }
- return true;
+
+ return errno == 0;
}
/* See nat/linux-nat.h. */