ac/nir: expand 64-bit vec3 loads to fix shuffling.
authorDave Airlie <airlied@redhat.com>
Mon, 30 Apr 2018 02:45:14 +0000 (12:45 +1000)
committerDave Airlie <airlied@redhat.com>
Mon, 30 Apr 2018 19:58:14 +0000 (05:58 +1000)
If loading 64-bit vec3 values, a 4 component load would be followed
by a 2 component load and the resulting shuffle would fail as it
requires 2 4 components. This just expands the second results
vector out to 4 components.

This fixes 100 CTS tests:
dEQP-VK.spirv_assembly.type.vec3.*64*

Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
src/amd/common/ac_nir_to_llvm.c

index e4ae6ef49ad608fedcd445705b0294f8f659ef22..b77d62a39b00868559eb33df964094a3bac5b478 100644 (file)
@@ -1572,6 +1572,11 @@ static LLVMValueRef visit_load_buffer(struct ac_nir_context *ctx,
                        LLVMConstInt(ctx->ac.i32, 6, false), LLVMConstInt(ctx->ac.i32, 7, false)
                };
 
+               if (num_components == 6) {
+                       /* we end up with a v4f32 and v2f32 but shuffle fails on that */
+                       results[1] = ac_build_expand_to_vec4(&ctx->ac, results[1], 4);
+               }
+
                LLVMValueRef swizzle = LLVMConstVector(masks, num_components);
                ret = LLVMBuildShuffleVector(ctx->ac.builder, results[0],
                                             results[num_components > 4 ? 1 : 0], swizzle, "");